Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Unified Diff: chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc

Issue 13456002: drive: Fills no-parent entiries in "/drive/other". (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add a comment in ConvertResourceEntryToDriveEntryProto(). Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/chromeos/drive/resource_entry_conversion.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc
diff --git a/chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc b/chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc
index ebd0ce5cf9e674739c0bdbaafd5dddcff18790ad..2d093e0fcafe0c397c0fef3d9b8e36b371c9432b 100644
--- a/chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc
+++ b/chrome/browser/chromeos/drive/resource_entry_conversion_unittest.cc
@@ -32,7 +32,7 @@ TEST(ResourceEntryConversionTest, ConvertResourceEntryToDriveEntryProto_File) {
EXPECT_EQ("https://file_content_url/", entry_proto.download_url());
EXPECT_EQ("https://file1_link_self/file:2_file_resource_id",
entry_proto.edit_url());
- EXPECT_EQ("", entry_proto.parent_resource_id());
+ EXPECT_EQ("<other>", entry_proto.parent_resource_id());
hidehiko 2013/04/03 07:55:40 nit: using util::kDriveOtherDirSpecialResourceId m
Haruki Sato 2013/04/04 06:16:06 Done. Thanks.
EXPECT_FALSE(entry_proto.deleted());
EXPECT_FALSE(entry_proto.shared_with_me());
@@ -115,7 +115,7 @@ TEST(ResourceEntryConversionTest,
EXPECT_EQ("https://3_document_content/", entry_proto.download_url());
EXPECT_EQ("https://3_document_self_link/document:5_document_resource_id",
entry_proto.edit_url());
- EXPECT_EQ("", entry_proto.parent_resource_id());
+ EXPECT_EQ("<other>", entry_proto.parent_resource_id());
EXPECT_FALSE(entry_proto.deleted());
EXPECT_FALSE(entry_proto.shared_with_me());
@@ -277,7 +277,7 @@ TEST(ResourceEntryConversionTest,
EXPECT_EQ("https://content_url/", entry_proto.download_url());
EXPECT_EQ("https://edit_url/document%3Adeleted_in_root_id",
entry_proto.edit_url());
- EXPECT_EQ("", entry_proto.parent_resource_id());
+ EXPECT_EQ("<other>", entry_proto.parent_resource_id());
EXPECT_TRUE(entry_proto.deleted()); // The document was deleted.
EXPECT_FALSE(entry_proto.shared_with_me());
« no previous file with comments | « chrome/browser/chromeos/drive/resource_entry_conversion.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698