drive: Fills no-parent entiries in "/drive/other".

chrome/browser/chromeos/drive/resource_entry_conversion.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/drive/resource_entry_conversion.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/logging.h"
@@ skipping 37 matching lines @@
   entry_proto.set_download_url(entry.download_url().spec());
 
   const google_apis::Link* edit_link =
       entry.GetLinkByType(google_apis::Link::LINK_EDIT);
   if (edit_link)
     entry_proto.set_edit_url(edit_link->href().spec());
 
   const google_apis::Link* parent_link =
       entry.GetLinkByType(google_apis::Link::LINK_PARENT);
   if (parent_link) {
-    // TODO(haruki): Apply mapping from an empty parent to special dummy
-    // directory. See http://crbug.com/174233. Until we implement it,
-    // ChangeListProcessor ignores such "no parent" entries.
     entry_proto.set_parent_resource_id(
         util::ExtractResourceIdFromUrl(parent_link->href()));
   }
 
+  // Apply mapping from an empty parent to the special dummy directory.
+  if (entry_proto.parent_resource_id().empty())
+    entry_proto.set_parent_resource_id(util::kDriveOtherDirSpecialResourceId);

[kinaba, 2013/04/03 05:39:33]

I'm not sure if this is the right place for this mapping,
because to me it seems to be a detail of ResourceMetadata that
it organizes orphan entries under drive/other.

Can we move the mapping to, say, ChangeListProcessor?

[kinaba, 2013/04/03 05:59:55]

Chatted offline, and inclined to feel ok to put it here.
(Many part of the Drive file system is touching directly resource metadata,
and it may not be good to add logic to resource metadata).

Instead, could you add a comment here (together with the conversion of
parent_link above)
that we are forcing a tree-shaped structure (= no multi-parent or zero-parent
entries),
maybe linking to http://crbug.com/158904?

[Haruki Sato, 2013/04/03 06:49:43]

Done.

+
   entry_proto.set_deleted(entry.deleted());
   entry_proto.set_kind(entry.kind());
   entry_proto.set_shared_with_me(HasSharedWithMeLabel(entry));
 
   PlatformFileInfoProto* file_info = entry_proto.mutable_file_info();
 
   file_info->set_last_modified(entry.updated_time().ToInternalValue());
   // If the file has never been viewed (last_viewed_time().is_null() == true),
   // then we will set the last_accessed field in the protocol buffer to 0.
   file_info->set_last_accessed(entry.last_viewed_time().ToInternalValue());
@@ skipping 52 matching lines @@
       entry_proto.set_upload_url(upload_link->href().spec());
   } else {
     // Some resource entries don't map into files (i.e. sites).
     return DriveEntryProto();
   }
 
   return entry_proto;
 }
 
 }  // namespace drive