Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Side by Side Diff: content/common/p2p_socket_type.h

Issue 1345583004: Wire up transport sequence number and send time. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments addressed. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // This file defines some basic types used by the P2P-related IPC 5 // This file defines some basic types used by the P2P-related IPC
6 // messages. 6 // messages.
7 7
8 #ifndef CONTENT_COMMON_P2P_SOCKET_TYPE_H_ 8 #ifndef CONTENT_COMMON_P2P_SOCKET_TYPE_H_
9 #define CONTENT_COMMON_P2P_SOCKET_TYPE_H_ 9 #define CONTENT_COMMON_P2P_SOCKET_TYPE_H_
10 10
11 #include <string> 11 #include <string>
12 12
13 #include "base/time/time.h"
13 #include "net/base/ip_endpoint.h" 14 #include "net/base/ip_endpoint.h"
14 15
15 namespace content { 16 namespace content {
16 17
17 enum P2PSocketOption { 18 enum P2PSocketOption {
18 P2P_SOCKET_OPT_RCVBUF, // Receive buffer size. 19 P2P_SOCKET_OPT_RCVBUF, // Receive buffer size.
19 P2P_SOCKET_OPT_SNDBUF, // Send buffer size. 20 P2P_SOCKET_OPT_SNDBUF, // Send buffer size.
20 P2P_SOCKET_OPT_DSCP, // DSCP code. 21 P2P_SOCKET_OPT_DSCP, // DSCP code.
21 P2P_SOCKET_OPT_MAX 22 P2P_SOCKET_OPT_MAX
22 }; 23 };
(...skipping 22 matching lines...) Expand all
45 } 46 }
46 47
47 std::string hostname; 48 std::string hostname;
48 net::IPEndPoint ip_address; 49 net::IPEndPoint ip_address;
49 }; 50 };
50 51
51 // Stuct which keeps track of metrics during a send operation on P2P sockets. 52 // Stuct which keeps track of metrics during a send operation on P2P sockets.
52 // Currently, it only carries packet_id but could be expanded to include 53 // Currently, it only carries packet_id but could be expanded to include
53 // timestamps when packet arrives at various points. 54 // timestamps when packet arrives at various points.
54 struct P2PSendPacketMetrics { 55 struct P2PSendPacketMetrics {
55 P2PSendPacketMetrics() : packet_id(0) {} 56 P2PSendPacketMetrics() {}
56 explicit P2PSendPacketMetrics(uint64_t packet_id) : packet_id(packet_id) {} 57 P2PSendPacketMetrics(uint64_t packet_id,
58 int32_t transport_sequence_number,
59 base::TimeTicks send_time_ticks)
60 : packet_id(packet_id),
61 transport_sequence_number(transport_sequence_number),
62 send_time_ticks(send_time_ticks) {}
57 63
58 uint64_t packet_id; 64 uint64_t packet_id = 0;
65 int32_t transport_sequence_number = -1;
Sergey Ulanov 2015/09/17 17:19:31 It's not clear what transport_sequence_number is a
Stefan 2015/09/18 07:56:51 Done.
66 base::TimeTicks send_time_ticks;
Sergey Ulanov 2015/09/17 17:19:31 nit: suggest calling it |send_time|, i.e. remove _
Stefan 2015/09/18 07:56:51 Done.
59 }; 67 };
60 68
61 } // namespace content 69 } // namespace content
62 70
63 #endif // CONTENT_COMMON_P2P_SOCKET_TYPE_H_ 71 #endif // CONTENT_COMMON_P2P_SOCKET_TYPE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698