Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1737)

Issue 1345583002: Add GetTimeTicksNow() to PlatformSupport. (Closed)

Created:
5 years, 3 months ago by viettrungluu
Modified:
5 years, 3 months ago
Reviewers:
kulakowski
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Add GetTimeTicksNow() to PlatformSupport. And convert some uses of base::TimeTicks (in particular, base::TimeTicks::Now()). Still to do: Convert the use in Waiter (which will require some injection). R=kulakowski@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/81937c3f013dd09b3930949841e611964c5ceb3d

Patch Set 1 #

Patch Set 2 : blech #

Total comments: 1

Patch Set 3 : clarify #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
M mojo/edk/embedder/BUILD.gn View 1 1 chunk +4 lines, -1 line 0 comments Download
M mojo/edk/embedder/platform_support.h View 1 2 2 chunks +18 lines, -0 lines 0 comments Download
M mojo/edk/embedder/simple_platform_support.h View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/edk/embedder/simple_platform_support.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/edk/system/BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M mojo/edk/system/core.cc View 2 chunks +1 line, -2 lines 0 comments Download
M mojo/edk/system/test_utils.h View 2 chunks +6 lines, -2 lines 0 comments Download
M mojo/edk/system/test_utils.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 3 months ago (2015-09-14 21:33:33 UTC) #1
kulakowski
lgtm assuming the BUILD.gn stuff is sensible (I'm not familiar with the build rules involved). ...
5 years, 3 months ago (2015-09-14 21:44:28 UTC) #2
viettrungluu
Thanks. On 2015/09/14 21:44:28, kulakowski wrote: > lgtm assuming the BUILD.gn stuff is sensible (I'm ...
5 years, 3 months ago (2015-09-14 21:56:23 UTC) #3
viettrungluu
5 years, 3 months ago (2015-09-14 22:02:25 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
81937c3f013dd09b3930949841e611964c5ceb3d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698