Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 1345543002: PPC: [Interpreter] Add support for JS calls. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Interpreter] Add support for JS calls. Port e7fb233946b990ecbbbd76cc6529f62bd5da64e3 Original commit message: Adds support for JS calls to the interpreter. In order to support calls from the interpreter, the PushArgsAndCall builtin is added which pushes a sequence of arguments onto the stack and calls builtin::Call. Adds the Call bytecode. R=rmcilroy@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG=v8:4280 LOG=N Committed: https://crrev.com/b6f673987f03667994b6918c89177f6a6c1c52c2 Cr-Commit-Position: refs/heads/master@{#30721}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -0 lines) Patch
M src/ppc/builtins-ppc.cc View 1 chunk +26 lines, -0 lines 0 comments Download
M src/ppc/interface-descriptors-ppc.cc View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
MTBrandyberry
5 years, 3 months ago (2015-09-14 18:55:39 UTC) #1
michael_dawson
On 2015/09/14 18:55:39, mtbrandyberry wrote: lgtm
5 years, 3 months ago (2015-09-14 18:59:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345543002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345543002/1
5 years, 3 months ago (2015-09-14 19:00:45 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 23:15:33 UTC) #5
commit-bot: I haz the power
5 years, 3 months ago (2015-09-14 23:15:52 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b6f673987f03667994b6918c89177f6a6c1c52c2
Cr-Commit-Position: refs/heads/master@{#30721}

Powered by Google App Engine
This is Rietveld 408576698