Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
134553002:
[Win] alt + space opens system menu at wrong position in RTL ui. (Closed)
|
Created:
6 years, 11 months ago by mmal Modified:
6 years, 9 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
Description[Win] alt + space opens system menu at wrong position in RTL ui.
When window is not maximized system menu opens on the left hand side and its
contents is partialy outside window bounds. After this fix when system menu
is opened using alt + space with RTL locale we draw it on the right hand side
and whole menu is inside browser window.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=259037
Patch Set 1 #
Messages
Total messages: 28 (0 generated)
Sorry about the delay... LGTM! BYE MAD
The CQ bit was checked by mmaliszkiewicz@opera.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmaliszkiewicz@opera.com/134553002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by mmaliszkiewicz@opera.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmaliszkiewicz@opera.com/134553002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by mmaliszkiewicz@opera.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmaliszkiewicz@opera.com/134553002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by mmaliszkiewicz@opera.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmaliszkiewicz@opera.com/134553002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
The CQ bit was checked by mmaliszkiewicz@opera.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmaliszkiewicz@opera.com/134553002/1
The CQ bit was unchecked by commit-bot@chromium.org
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...
** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
ui/gfx/win/hwnd_util.cc
-----------------------------------------------
Am I doing this wrong or something broke?
On 2014/03/10 10:55:50, mmaliszkiewicz wrote: > ** Presubmit ERRORS ** > Missing LGTM from an OWNER for these files: > ui/gfx/win/hwnd_util.cc > ----------------------------------------------- > > Am I doing this wrong or something broke? It just means that you need to find one more reviewer. Looking at files, I suggest asking ben@chromium.org. In this system it's the code author and CQ that tracks whether the code is properly reviewed, not as we're used to from Critic, that the review system locates reviewers and keep track of whether the code is reviewed or not.
lgtm
The CQ bit was checked by mmaliszkiewicz@opera.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mmaliszkiewicz@opera.com/134553002/1
Message was sent while issue was closed.
Change committed as 259037 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
