Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc

Issue 1345523005: Added command line flag to override list of proxies from Data Saver API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebased on master Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..e11fb72f4fb77f61bc6d10e12a02c28a499ef0a1
--- /dev/null
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values_unittest.cc
@@ -0,0 +1,93 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/data_reduction_proxy/core/browser/data_reduction_proxy_mutable_config_values.h"
+
+#include <vector>
+
+#include "base/command_line.h"
+#include "base/memory/scoped_ptr.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_params.h"
+#include "components/data_reduction_proxy/core/common/data_reduction_proxy_switches.h"
+#include "net/proxy/proxy_server.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace data_reduction_proxy {
+
+namespace {
+
+class DataReductionProxyMutableConfigValuesTest : public testing::Test {
+ public:
+ DataReductionProxyMutableConfigValuesTest() {}
+ ~DataReductionProxyMutableConfigValuesTest() override {}
+
+ void Init() {
+ params_.reset(new DataReductionProxyParams(
+ DataReductionProxyParams::kAllowAllProxyConfigurations));
+ mutable_config_values_ =
+ DataReductionProxyMutableConfigValues::CreateFromParams(params_.get());
+ }
+
+ DataReductionProxyMutableConfigValues* mutable_config_values() const {
+ return mutable_config_values_.get();
+ }
+
+ private:
+ scoped_ptr<DataReductionProxyParams> params_;
+ scoped_ptr<DataReductionProxyMutableConfigValues> mutable_config_values_;
+};
+
+TEST_F(DataReductionProxyMutableConfigValuesTest, UpdateValuesAndInvalidate) {
+ Init();
+ EXPECT_EQ(std::vector<net::ProxyServer>(),
+ mutable_config_values()->proxies_for_http());
+
+ std::vector<net::ProxyServer> proxies_for_http;
+ proxies_for_http.push_back(net::ProxyServer::FromURI(
+ "http://first.net", net::ProxyServer::SCHEME_HTTP));
+ proxies_for_http.push_back(net::ProxyServer::FromURI(
+ "http://second.net", net::ProxyServer::SCHEME_HTTP));
+
+ mutable_config_values()->UpdateValues(proxies_for_http);
+ EXPECT_EQ(proxies_for_http, mutable_config_values()->proxies_for_http());
+
+ mutable_config_values()->Invalidate();
+ EXPECT_EQ(std::vector<net::ProxyServer>(),
+ mutable_config_values()->proxies_for_http());
+}
+
+TEST_F(DataReductionProxyMutableConfigValuesTest, OverrideProxiesForHttp) {
+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(
+ switches::kDataReductionProxyHttpProxies,
+ "http://override-first.net;http://override-second.net");
+ Init();
+
+ EXPECT_EQ(std::vector<net::ProxyServer>(),
+ mutable_config_values()->proxies_for_http());
+
+ std::vector<net::ProxyServer> proxies_for_http;
+ proxies_for_http.push_back(net::ProxyServer::FromURI(
+ "http://first.net", net::ProxyServer::SCHEME_HTTP));
+ proxies_for_http.push_back(net::ProxyServer::FromURI(
+ "http://second.net", net::ProxyServer::SCHEME_HTTP));
+
+ mutable_config_values()->UpdateValues(proxies_for_http);
+
+ std::vector<net::ProxyServer> expected_override_proxies_for_http;
+ expected_override_proxies_for_http.push_back(net::ProxyServer::FromURI(
+ "http://override-first.net", net::ProxyServer::SCHEME_HTTP));
+ expected_override_proxies_for_http.push_back(net::ProxyServer::FromURI(
+ "http://override-second.net", net::ProxyServer::SCHEME_HTTP));
+
+ EXPECT_EQ(expected_override_proxies_for_http,
+ mutable_config_values()->proxies_for_http());
+
+ mutable_config_values()->Invalidate();
+ EXPECT_EQ(std::vector<net::ProxyServer>(),
+ mutable_config_values()->proxies_for_http());
+}
+
+} // namespace
+
+} // namespace data_reduction_proxy

Powered by Google App Engine
This is Rietveld 408576698