we must own/free the generator, even if we fail to return a cacherator

we must own/free the generator, even if we fail to return a cacherator

BUG=skia:4332
Committed: https://skia.googlesource.com/skia/+/3a100d3e4de7a640d558352c544724801ab842f3

[reed1, 2015-09-14 16:06:37]

reed@google.com changed reviewers:
+ tomhudson@google.com

[reed1, 2015-09-14 16:06:37]

ptal

[reed1, 2015-09-14 16:06:39]

The CQ bit was checked by reed@google.com

[commit-bot: I haz the power, 2015-09-14 16:06:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1345523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1345523002/1

[commit-bot: I haz the power, 2015-09-14 16:06:50]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2015-09-14 22:06 UTC

[tomhudson, 2015-09-14 16:58:16]

lgtm

Modulo nits...

https://codereview.chromium.org/1345523002/diff/1/src/core/SkImageCacherator.cpp
File src/core/SkImageCacherator.cpp (right):

https://codereview.chromium.org/1345523002/diff/1/src/core/SkImageCacherator....
src/core/SkImageCacherator.cpp:54: // release our holder. (we DONT want to
delete it here anymore)
Nit: two words "any more" unless you're Edgar Allen Poe?
(And maybe an apostrophe in DONT)

[commit-bot: I haz the power, 2015-09-14 16:59:32]

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3a100d3e4de7a640d558352c544724801ab842f3