Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1345483002: Create a RenderProcess message class and move keygen to it. (Closed)

Created:
5 years, 3 months ago by Avi (use Gerrit)
Modified:
5 years, 2 months ago
Reviewers:
ncarter (slow), nasko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create a RenderProcess message class and move keygen to it. Among everything else it does, this reverts commit 5d4a2a91096ffce9d44b0850c288da6bb57bc7c6. BUG=304341 TEST=none Committed: https://crrev.com/914d82eea67d38ccd8e94932226711f075e5bc33 Cr-Commit-Position: refs/heads/master@{#348674}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : tweak #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -83 lines) Patch
M content/browser/frame_host/render_frame_message_filter.h View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/frame_host/render_frame_message_filter.cc View 4 chunks +0 lines, -63 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.h View 2 chunks +7 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 2 5 chunks +63 lines, -0 lines 0 comments Download
M content/common/content_message_generator.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +0 lines, -9 lines 0 comments Download
A content/common/render_process_messages.h View 1 1 chunk +32 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M ipc/ipc_message_start.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 19 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345483002/1
5 years, 3 months ago (2015-09-14 15:16:11 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/81260)
5 years, 3 months ago (2015-09-14 15:28:36 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345483002/20001
5 years, 3 months ago (2015-09-14 15:47:29 UTC) #6
Avi (use Gerrit)
5 years, 3 months ago (2015-09-14 16:18:54 UTC) #8
Avi (use Gerrit)
The idea here is that we'll keep RenderMessageFilter, but it'll only host child process and ...
5 years, 3 months ago (2015-09-14 16:19:50 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-14 17:13:14 UTC) #11
nasko
LGTM with a nit. https://codereview.chromium.org/1345483002/diff/20001/content/browser/renderer_host/render_message_filter.cc File content/browser/renderer_host/render_message_filter.cc (right): https://codereview.chromium.org/1345483002/diff/20001/content/browser/renderer_host/render_message_filter.cc#newcode170 content/browser/renderer_host/render_message_filter.cc:170: IPC_MESSAGE_HANDLER_DELAY_REPLY(RenderProcessHostMsg_Keygen, OnKeygen) nit: Move this ...
5 years, 3 months ago (2015-09-14 17:20:45 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345483002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345483002/40001
5 years, 3 months ago (2015-09-14 17:30:08 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 3 months ago (2015-09-14 19:04:20 UTC) #16
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/914d82eea67d38ccd8e94932226711f075e5bc33 Cr-Commit-Position: refs/heads/master@{#348674}
5 years, 3 months ago (2015-09-14 19:05:10 UTC) #17
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/914d82eea67d38ccd8e94932226711f075e5bc33 Cr-Commit-Position: refs/heads/master@{#348674}
5 years, 3 months ago (2015-09-23 12:35:19 UTC) #18
Avi (use Gerrit)
5 years, 2 months ago (2015-09-25 04:59:31 UTC) #19
Message was sent while issue was closed. 
https://codereview.chromium.org/1345483002/diff/20001/content/browser/rendere...
File content/browser/renderer_host/render_message_filter.cc (right):

https://codereview.chromium.org/1345483002/diff/20001/content/browser/rendere...
content/browser/renderer_host/render_message_filter.cc:170:
IPC_MESSAGE_HANDLER_DELAY_REPLY(RenderProcessHostMsg_Keygen, OnKeygen)
On 2015/09/14 17:20:45, nasko (slow to review) wrote:
> nit: Move this above the ViewHostMsg_DidGenerateCacheableMetadata, so all IPCs
> of the same type are together.

Done.

Powered by Google App Engine
This is Rietveld 408576698