Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issue 1345443002: Whitelist another StrictMode violation. (Closed)

Created:
5 years, 3 months ago by Yaron
Modified:
5 years, 3 months ago
Reviewers:
Peter Wen, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Whitelist another StrictMode violation. It appears to do both a read and a write on KK. Whitelist the write. BUG=527415 TBR=agrieve Committed: https://crrev.com/b1068c58d5c2a1cd4534e57c6e08eb6c976827cb Cr-Commit-Position: refs/heads/master@{#348614}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationHandler.java View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
Yaron
5 years, 3 months ago (2015-09-14 13:49:09 UTC) #2
Peter Wen
On 2015/09/14 13:49:09, Yaron wrote: lgtm
5 years, 3 months ago (2015-09-14 13:49:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345443002/1
5 years, 3 months ago (2015-09-14 14:00:26 UTC) #5
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 3 months ago (2015-09-14 14:00:27 UTC) #7
Yaron
tbr'ing agrieve as full-committer
5 years, 3 months ago (2015-09-14 14:01:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345443002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345443002/1
5 years, 3 months ago (2015-09-14 14:01:48 UTC) #11
agrieve
On 2015/09/14 14:01:48, commit-bot: I haz the power wrote: > CQ is trying da patch. ...
5 years, 3 months ago (2015-09-14 14:13:37 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-14 14:28:42 UTC) #13
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b1068c58d5c2a1cd4534e57c6e08eb6c976827cb Cr-Commit-Position: refs/heads/master@{#348614}
5 years, 3 months ago (2015-09-14 14:29:12 UTC) #14
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 12:32:20 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b1068c58d5c2a1cd4534e57c6e08eb6c976827cb
Cr-Commit-Position: refs/heads/master@{#348614}

Powered by Google App Engine
This is Rietveld 408576698