Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1345423002: Introduce WebNode::querySelectorAll. (Closed)

Created:
5 years, 3 months ago by esprehn
Modified:
5 years, 3 months ago
Reviewers:
pdr., dglazkov, ojan
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Introduce WebNode::querySelectorAll. This will let us replace getElementsByHTMLTagName with an API that doesn't use live node lists. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -10 lines) Patch
M Source/web/WebNode.cpp View 2 chunks +21 lines, -4 lines 0 comments Download
M Source/web/WebNodeTest.cpp View 2 chunks +77 lines, -5 lines 0 comments Download
M public/web/WebNode.h View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (4 generated)
esprehn
5 years, 3 months ago (2015-09-17 01:08:38 UTC) #2
dglazkov
lgtm
5 years, 3 months ago (2015-09-17 01:11:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345423002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345423002/1
5 years, 3 months ago (2015-09-17 01:11:33 UTC) #7
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 02:37:44 UTC) #8
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202417

Powered by Google App Engine
This is Rietveld 408576698