chrome/browser/profiles/dependency_node.h - Issue 13454032: Extract DependencyGraph from ProfileDependencyManager.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/profiles/dependency_node.h

Issue 13454032: Extract DependencyGraph from ProfileDependencyManager. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: no void* Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2013 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_PROFILES_DEPENDENCY_NODE_H_

	6 #define CHROME_BROWSER_PROFILES_DEPENDENCY_NODE_H_

	7

	8 class DependencyNode {

	9 protected:

	10 DependencyNode() {}

	11 ~DependencyNode() {}
	Elliot Glaysher 2013/04/12 20:15:06 does this need to be virtual? does this need to be virtual? Paweł Hajdan Jr. 2013/04/12 23:00:00 I don't think it's needed - it seems there is a ge Show quoted text On 2013/04/12 20:15:06, Elliot Glaysher wrote: > does this need to be virtual? I don't think it's needed - it seems there is a general preference not to make a class require vptr unless necessary, so I'm trying to follow that here. That would be different if it was a real interface with virtual methods, or if we'd be destroying objects using DependencyNode* .
	12 };

	13

	14 #endif // CHROME_BROWSER_PROFILES_DEPENDENCY_NODE_H_

OLD	NEW