Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Unified Diff: Source/WebCore/platform/graphics/MediaPlayer.cpp

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/platform/graphics/MediaPlayer.cpp
diff --git a/Source/WebCore/platform/graphics/MediaPlayer.cpp b/Source/WebCore/platform/graphics/MediaPlayer.cpp
index f275806cd652b14f1ccc84a76501f0e621f0dcae..e6e1ae3fbdfe92fcbb1d6bcc7e69406692a01a58 100644
--- a/Source/WebCore/platform/graphics/MediaPlayer.cpp
+++ b/Source/WebCore/platform/graphics/MediaPlayer.cpp
@@ -85,17 +85,17 @@ public:
virtual void setVisible(bool) { }
- virtual float duration() const { return 0; }
+ virtual double duration() const { return 0; }
- virtual float currentTime() const { return 0; }
- virtual void seek(float) { }
+ virtual double currentTime() const { return 0; }
+ virtual void seek(double) { }
virtual bool seeking() const { return false; }
- virtual void setRate(float) { }
+ virtual void setRate(double) { }
virtual void setPreservesPitch(bool) { }
virtual bool paused() const { return false; }
- virtual void setVolume(float) { }
+ virtual void setVolume(double) { }
virtual bool supportsMuting() const { return false; }
virtual void setMuted(bool) { }
@@ -106,7 +106,7 @@ public:
virtual MediaPlayer::NetworkState networkState() const { return MediaPlayer::Empty; }
virtual MediaPlayer::ReadyState readyState() const { return MediaPlayer::HaveNothing; }
- virtual float maxTimeSeekable() const { return 0; }
+ virtual double maxTimeSeekable() const { return 0; }
virtual PassRefPtr<TimeRanges> buffered() const { return TimeRanges::create(); }
virtual unsigned totalBytes() const { return 0; }
@@ -461,12 +461,12 @@ MediaPlayer::MediaKeyException MediaPlayer::cancelKeyRequest(const String& keySy
}
#endif
-float MediaPlayer::duration() const
+double MediaPlayer::duration() const
{
return m_private->duration();
}
-float MediaPlayer::startTime() const
+double MediaPlayer::startTime() const
{
return m_private->startTime();
}
@@ -476,12 +476,12 @@ double MediaPlayer::initialTime() const
return m_private->initialTime();
}
-float MediaPlayer::currentTime() const
+double MediaPlayer::currentTime() const
{
return m_private->currentTime();
}
-void MediaPlayer::seek(float time)
+void MediaPlayer::seek(double time)
{
m_private->seek(time);
}
@@ -554,12 +554,12 @@ MediaPlayer::ReadyState MediaPlayer::readyState()
return m_private->readyState();
}
-float MediaPlayer::volume() const
+double MediaPlayer::volume() const
{
return m_volume;
}
-void MediaPlayer::setVolume(float volume)
+void MediaPlayer::setVolume(double volume)
{
m_volume = volume;
@@ -592,15 +592,15 @@ void MediaPlayer::setClosedCaptionsVisible(bool closedCaptionsVisible)
m_private->setClosedCaptionsVisible(closedCaptionsVisible);
}
-float MediaPlayer::rate() const
+double MediaPlayer::rate() const
{
return m_rate;
}
-void MediaPlayer::setRate(float rate)
+void MediaPlayer::setRate(double rate)
{
m_rate = rate;
- m_private->setRate(rate);
+ m_private->setRate(rate);
}
bool MediaPlayer::preservesPitch() const
@@ -624,7 +624,7 @@ PassRefPtr<TimeRanges> MediaPlayer::seekable()
return m_private->seekable();
}
-float MediaPlayer::maxTimeSeekable()
+double MediaPlayer::maxTimeSeekable()
{
return m_private->maxTimeSeekable();
}
@@ -783,7 +783,7 @@ MediaPlayer::MovieLoadType MediaPlayer::movieLoadType() const
return m_private->movieLoadType();
}
-float MediaPlayer::mediaTimeForTimeValue(float timeValue) const
+double MediaPlayer::mediaTimeForTimeValue(double timeValue) const
{
return m_private->mediaTimeForTimeValue(timeValue);
}
@@ -881,7 +881,7 @@ void MediaPlayer::readyStateChanged()
m_mediaPlayerClient->mediaPlayerReadyStateChanged(this);
}
-void MediaPlayer::volumeChanged(float newVolume)
+void MediaPlayer::volumeChanged(double newVolume)
{
m_volume = newVolume;
if (m_mediaPlayerClient)
« no previous file with comments | « Source/WebCore/platform/graphics/MediaPlayer.h ('k') | Source/WebCore/platform/graphics/MediaPlayerPrivate.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698