Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: Source/WebCore/html/HTMLMediaElement.h

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/media/video-volume-expected.txt ('k') | Source/WebCore/html/HTMLMediaElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/WebCore/html/HTMLMediaElement.h
diff --git a/Source/WebCore/html/HTMLMediaElement.h b/Source/WebCore/html/HTMLMediaElement.h
index d04f3c5ee4435fb9cd7f0295871bb728a3bfd5c9..8baf22671affd5d9e61b3a401d363e5a63b07b96 100644
--- a/Source/WebCore/html/HTMLMediaElement.h
+++ b/Source/WebCore/html/HTMLMediaElement.h
@@ -96,7 +96,7 @@ public:
virtual bool hasVideo() const { return false; }
virtual bool hasAudio() const;
- void rewind(float timeDelta);
+ void rewind(double timeDelta);
void returnToRealtime();
// Eventually overloaded in HTMLVideoElement
@@ -144,16 +144,16 @@ public:
bool seeking() const;
// playback state
- float currentTime() const;
- void setCurrentTime(float, ExceptionCode&);
+ double currentTime() const;
+ void setCurrentTime(double, ExceptionCode&);
double initialTime() const;
- float startTime() const;
- float duration() const;
+ double startTime() const;
+ double duration() const;
bool paused() const;
- float defaultPlaybackRate() const;
- void setDefaultPlaybackRate(float);
- float playbackRate() const;
- void setPlaybackRate(float);
+ double defaultPlaybackRate() const;
+ void setDefaultPlaybackRate(double);
+ double playbackRate() const;
+ void setPlaybackRate(double);
void updatePlaybackRate();
bool webkitPreservesPitch() const;
void setWebkitPreservesPitch(bool);
@@ -204,8 +204,8 @@ public:
// controls
bool controls() const;
void setControls(bool);
- float volume() const;
- void setVolume(float, ExceptionCode&);
+ double volume() const;
+ void setVolume(double, ExceptionCode&);
bool muted() const;
void setMuted(bool);
@@ -215,7 +215,7 @@ public:
bool canPlay() const;
- float percentLoaded() const;
+ double percentLoaded() const;
#if ENABLE(VIDEO_TRACK)
PassRefPtr<TextTrack> addTextTrack(const String& kind, const String& label, const String& language, ExceptionCode&);
@@ -490,10 +490,10 @@ private:
void startProgressEventTimer();
void stopPeriodicTimers();
- void seek(float time, ExceptionCode&);
+ void seek(double time, ExceptionCode&);
void finishSeek();
void checkIfSeekNeeded();
- void addPlayedRange(float start, float end);
+ void addPlayedRange(double start, double end);
void scheduleTimeupdateEvent(bool periodicEvent);
void scheduleEvent(const AtomicString& eventName);
@@ -517,7 +517,7 @@ private:
void mediaLoadingFailed(MediaPlayer::NetworkState);
#if ENABLE(VIDEO_TRACK)
- void updateActiveTextTrackCues(float);
+ void updateActiveTextTrackCues(double);
HTMLTrackElement* showingTrackWithSameKind(HTMLTrackElement*) const;
void markCaptionAndSubtitleTracksAsUnconfigured();
@@ -544,13 +544,13 @@ private:
bool pausedForUserInteraction() const;
bool couldPlayIfEnoughData() const;
- float minTimeSeekable() const;
- float maxTimeSeekable() const;
+ double minTimeSeekable() const;
+ double maxTimeSeekable() const;
// Pauses playback without changing any states or generating events
void setPausedInternal(bool);
- void setPlaybackRateInternal(float);
+ void setPlaybackRateInternal(double);
virtual void mediaCanStart();
@@ -594,8 +594,8 @@ private:
RefPtr<TimeRanges> m_playedTimeRanges;
OwnPtr<GenericEventQueue> m_asyncEventQueue;
- float m_playbackRate;
- float m_defaultPlaybackRate;
+ double m_playbackRate;
+ double m_defaultPlaybackRate;
bool m_webkitPreservesPitch;
NetworkState m_networkState;
ReadyState m_readyState;
@@ -604,8 +604,8 @@ private:
RefPtr<MediaError> m_error;
- float m_volume;
- float m_lastSeekTime;
+ double m_volume;
+ double m_lastSeekTime;
unsigned m_previousProgress;
double m_previousProgressTime;
@@ -614,7 +614,7 @@ private:
double m_lastTimeUpdateEventWallTime;
// The last time a timeupdate event was sent in movie time.
- float m_lastTimeUpdateEventMovieTime;
+ double m_lastTimeUpdateEventMovieTime;
// Loading state.
enum LoadState { WaitingForSource, LoadingFromSrcAttr, LoadingFromSourceElement };
@@ -639,7 +639,7 @@ private:
RefPtr<MediaSource> m_mediaSource;
- mutable float m_cachedTime;
+ mutable double m_cachedTime;
mutable double m_cachedTimeWallClockUpdateTime;
mutable double m_minimumWallClockTimeToCacheMediaTime;
@@ -688,7 +688,7 @@ private:
bool m_tracksAreReady : 1;
bool m_haveVisibleTextTrack : 1;
bool m_processingPreferenceChange : 1;
- float m_lastTextTrackUpdateTime;
+ double m_lastTextTrackUpdateTime;
RefPtr<TextTrackList> m_textTracks;
Vector<RefPtr<TextTrack> > m_textTracksWhenResourceSelectionBegan;
« no previous file with comments | « LayoutTests/media/video-volume-expected.txt ('k') | Source/WebCore/html/HTMLMediaElement.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698