Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Unified Diff: Source/WebKit/chromium/public/WebMediaPlayer.h

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed GTK change since the file is gone now. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/public/WebMediaPlayer.h
diff --git a/Source/WebKit/chromium/public/WebMediaPlayer.h b/Source/WebKit/chromium/public/WebMediaPlayer.h
index 749f03860c779d8120a98c527e26302cb0b3f0b5..3d14f8bd4df29e6d18f099f8db03493325c103df 100644
--- a/Source/WebKit/chromium/public/WebMediaPlayer.h
+++ b/Source/WebKit/chromium/public/WebMediaPlayer.h
@@ -105,14 +105,19 @@ public:
virtual void pause() = 0;
virtual bool supportsFullscreen() const = 0;
virtual bool supportsSave() const = 0;
+ virtual void seekFloat(float seconds) { seek(seconds); }
virtual void seek(float seconds) = 0;
+ virtual void setEndTimeFloat(float seconds) { setEndTime(seconds); }
virtual void setEndTime(float seconds) = 0;
+ virtual void setRateFloat(float rate) { setRate(rate); }
virtual void setRate(float) = 0;
+ virtual void setVolumeFloat(float volume) { setVolume(volume); }
virtual void setVolume(float) = 0;
virtual void setVisible(bool) = 0;
virtual void setPreload(Preload) { };
virtual bool totalBytesKnown() = 0;
virtual const WebTimeRanges& buffered() = 0;
+ virtual float maxTimeSeekableFloat() const { return maxTimeSeekable(); }
virtual float maxTimeSeekable() const = 0;
virtual void setSize(const WebSize&) = 0;
@@ -129,7 +134,9 @@ public:
// Getters of playback state.
virtual bool paused() const = 0;
virtual bool seeking() const = 0;
+ virtual float durationFloat() const { return duration(); }
virtual float duration() const = 0;
+ virtual float currentTimeFloat() const { return currentTime(); }
virtual float currentTime() const = 0;
// Get rate of loading the resource.
@@ -146,6 +153,7 @@ public:
virtual bool didPassCORSAccessCheck() const = 0;
virtual MovieLoadType movieLoadType() const = 0;
+ virtual float mediaTimeForTimeValueFloat(float timeValue) const { return mediaTimeForTimeValue(timeValue); }
virtual float mediaTimeForTimeValue(float timeValue) const = 0;
virtual unsigned decodedFrameCount() const = 0;

Powered by Google App Engine
This is Rietveld 408576698