Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(299)

Unified Diff: Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change WebMediaPlayer to only have the xxxFloat methods. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h
diff --git a/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h b/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h
index 6ac84806b748185aa5a570e3c3f39e9427db2772..5d3f70c0647c039c6c41929ea88c4105300e4c4f 100644
--- a/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h
+++ b/Source/WebKit/chromium/src/WebMediaPlayerClientImpl.h
@@ -64,7 +64,7 @@ public:
virtual ~WebMediaPlayerClientImpl();
virtual void networkStateChanged();
virtual void readyStateChanged();
- virtual void volumeChanged(float);
+ virtual void volumeChanged(double);
virtual void muteChanged(bool);
virtual void timeChanged();
virtual void repaint();
@@ -73,7 +73,7 @@ public:
virtual void sizeChanged();
virtual void setOpaque(bool);
virtual void sawUnsupportedTracks();
- virtual float volume() const;
+ virtual double volume() const;
virtual void playbackStateChanged();
virtual WebMediaPlayer::Preload preload() const;
virtual void keyAdded(const WebString& keySystem, const WebString& sessionId);
@@ -103,17 +103,17 @@ public:
virtual bool hasVideo() const;
virtual bool hasAudio() const;
virtual void setVisible(bool);
- virtual float duration() const;
- virtual float currentTime() const;
- virtual void seek(float time);
+ virtual double duration() const;
+ virtual double currentTime() const;
+ virtual void seek(double time);
virtual bool seeking() const;
- virtual void setEndTime(float time);
- virtual void setRate(float);
+ virtual void setEndTime(double time);
+ virtual void setRate(double);
virtual bool paused() const;
- virtual void setVolume(float);
+ virtual void setVolume(double);
virtual WebCore::MediaPlayer::NetworkState networkState() const;
virtual WebCore::MediaPlayer::ReadyState readyState() const;
- virtual float maxTimeSeekable() const;
+ virtual double maxTimeSeekable() const;
virtual WTF::PassRefPtr<WebCore::TimeRanges> buffered() const;
virtual int dataRate() const;
virtual bool totalBytesKnown() const;
@@ -127,7 +127,7 @@ public:
virtual bool hasSingleSecurityOrigin() const;
virtual bool didPassCORSAccessCheck() const;
virtual WebCore::MediaPlayer::MovieLoadType movieLoadType() const;
- virtual float mediaTimeForTimeValue(float timeValue) const;
+ virtual double mediaTimeForTimeValue(double timeValue) const;
virtual unsigned decodedFrameCount() const;
virtual unsigned droppedFrameCount() const;
virtual unsigned audioDecodedByteCount() const;

Powered by Google App Engine
This is Rietveld 408576698