Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: Source/WebCore/platform/graphics/MediaPlayerPrivate.h

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change WebMediaPlayer to only have the xxxFloat methods. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/platform/graphics/MediaPlayerPrivate.h
diff --git a/Source/WebCore/platform/graphics/MediaPlayerPrivate.h b/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
index a7d49f94b33785a78c912c05a47dd5f8ba936571..ca5f9e37f37bb6c09304a2df1e5eeeb777a4c0aa 100644
--- a/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
+++ b/Source/WebCore/platform/graphics/MediaPlayerPrivate.h
@@ -68,22 +68,24 @@ public:
virtual void setVisible(bool) = 0;
- virtual float duration() const = 0;
+ virtual double duration() const { return 0; }
- virtual float currentTime() const = 0;
- virtual void seek(float time) = 0;
- virtual bool seeking() const = 0;
+ virtual double currentTime() const { return 0; }
+
+ virtual void seek(double) { }
- virtual float startTime() const { return 0; }
+ virtual bool seeking() const = 0;
+ virtual double startTime() const { return 0; }
virtual double initialTime() const { return 0; }
- virtual void setRate(float) = 0;
+ virtual void setRate(double) { }
+
virtual void setPreservesPitch(bool) { }
virtual bool paused() const = 0;
- virtual void setVolume(float) = 0;
+ virtual void setVolume(double) { }
virtual bool supportsMuting() const { return false; }
virtual void setMuted(bool) { }
@@ -95,7 +97,7 @@ public:
virtual MediaPlayer::ReadyState readyState() const = 0;
virtual PassRefPtr<TimeRanges> seekable() const { return maxTimeSeekable() ? TimeRanges::create(0, maxTimeSeekable()) : TimeRanges::create(); }
- virtual float maxTimeSeekable() const = 0;
+ virtual double maxTimeSeekable() const { return 0; }
virtual PassRefPtr<TimeRanges> buffered() const = 0;
virtual bool didLoadingProgress() const = 0;
@@ -146,7 +148,7 @@ public:
// Time value in the movie's time scale. It is only necessary to override this if the media
// engine uses rational numbers to represent media time.
- virtual float mediaTimeForTimeValue(float timeValue) const { return timeValue; }
+ virtual double mediaTimeForTimeValue(double timeValue) const { return timeValue; }
// Overide this if it is safe for HTMLMediaElement to cache movie time and report
// 'currentTime' as [cached time + elapsed wall time]. Returns the maximum wall time

Powered by Google App Engine
This is Rietveld 408576698