Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: Source/WebCore/platform/graphics/MediaPlayer.h

Issue 13454026: Update all float attributes in HTMLMediaElement and related objects to double (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Change WebMediaPlayer to only have the xxxFloat methods. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/WebCore/platform/graphics/MediaPlayer.h
diff --git a/Source/WebCore/platform/graphics/MediaPlayer.h b/Source/WebCore/platform/graphics/MediaPlayer.h
index 4745d9c3e59dce61a33acf74e1d68c2ff3363777..76cc6ebfd29eeb40f8ff07ed7f51472df3604b45 100644
--- a/Source/WebCore/platform/graphics/MediaPlayer.h
+++ b/Source/WebCore/platform/graphics/MediaPlayer.h
@@ -294,29 +294,29 @@ public:
bool paused() const;
bool seeking() const;
- static float invalidTime() { return -1.0f;}
- float duration() const;
- float currentTime() const;
- void seek(float time);
+ static double invalidTime() { return -1.0;}
+ double duration() const;
+ double currentTime() const;
+ void seek(double time);
- float startTime() const;
+ double startTime() const;
double initialTime() const;
- float rate() const;
- void setRate(float);
+ double rate() const;
+ void setRate(double);
bool preservesPitch() const;
void setPreservesPitch(bool);
PassRefPtr<TimeRanges> buffered();
PassRefPtr<TimeRanges> seekable();
- float maxTimeSeekable();
+ double maxTimeSeekable();
bool didLoadingProgress();
- float volume() const;
- void setVolume(float);
+ double volume() const;
+ void setVolume(double);
bool muted() const;
void setMuted(bool);
@@ -360,7 +360,7 @@ public:
void networkStateChanged();
void readyStateChanged();
- void volumeChanged(float);
+ void volumeChanged(double);
void muteChanged(bool);
void timeChanged();
void sizeChanged();
@@ -410,7 +410,7 @@ public:
bool didPassCORSAccessCheck() const;
- float mediaTimeForTimeValue(float) const;
+ double mediaTimeForTimeValue(double) const;
double maximumDurationToCacheMediaTime() const;
@@ -481,8 +481,8 @@ private:
IntSize m_size;
Preload m_preload;
bool m_visible;
- float m_rate;
- float m_volume;
+ double m_rate;
+ double m_volume;
bool m_muted;
bool m_preservesPitch;
bool m_privateBrowsing;

Powered by Google App Engine
This is Rietveld 408576698