Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(808)

Issue 13454019: Fix bug in bignum implementation. (Closed)

Created:
7 years, 8 months ago by Yang
Modified:
7 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix bug in bignum implementation. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=14167

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M src/bignum.cc View 1 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Yang
7 years, 8 months ago (2013-04-05 15:11:41 UTC) #1
Yang
On 2013/04/05 15:11:41, Yang wrote: Please take a look. I included a regression test in ...
7 years, 8 months ago (2013-04-08 09:28:42 UTC) #2
Michael Starzinger
LGTM. I like this second version much better than the first.
7 years, 8 months ago (2013-04-08 11:30:55 UTC) #3
Yang
Committed patchset #2 manually as r14167 (presubmit successful).
7 years, 8 months ago (2013-04-08 15:14:04 UTC) #4
floitsch
7 years, 8 months ago (2013-04-25 17:07:16 UTC) #5
Message was sent while issue was closed.
FYI: I just fixed this bug in the double-conversion library and investigated.

The SubtractTimes function is only called with values that have at most a
difference of one bigint. This means that the loop never executes more than
once. The spurious i++ therefore didn't have any effect.

Powered by Google App Engine
This is Rietveld 408576698