Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: pdf/pdfium/pdfium_page.h

Issue 1345393005: Cleanup: Pass std::string as const reference from pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_page.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pdf/pdfium/pdfium_page.h
diff --git a/pdf/pdfium/pdfium_page.h b/pdf/pdfium/pdfium_page.h
index 3cca04c67168992bcd39f377f4107f7e321b7d7a..eee57e0f76c8173ce5e342ab0b50a4ab6262946c 100644
--- a/pdf/pdfium/pdfium_page.h
+++ b/pdf/pdfium/pdfium_page.h
@@ -109,8 +109,8 @@ class PDFiumPage {
base::Value* GetTextBoxAsValue(double page_height, double left, double top,
double right, double bottom, int rotation);
// Helper functions for JSON generation
- base::Value* CreateTextNode(std::string text);
- base::Value* CreateURLNode(std::string text, std::string url);
+ base::Value* CreateTextNode(const std::string& text);
+ base::Value* CreateURLNode(const std::string& text, const std::string& url);
class ScopedLoadCounter {
public:
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698