Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Side by Side Diff: pdf/pdfium/pdfium_page.h

Issue 1345393005: Cleanup: Pass std::string as const reference from pdf/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_page.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef PDF_PDFIUM_PDFIUM_PAGE_H_ 5 #ifndef PDF_PDFIUM_PDFIUM_PAGE_H_
6 #define PDF_PDFIUM_PDFIUM_PAGE_H_ 6 #define PDF_PDFIUM_PDFIUM_PAGE_H_
7 7
8 #include <string> 8 #include <string>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 void CalculateLinks(); 102 void CalculateLinks();
103 // Returns link type and target associated with a link. Returns 103 // Returns link type and target associated with a link. Returns
104 // NONSELECTABLE_AREA if link detection failed. 104 // NONSELECTABLE_AREA if link detection failed.
105 Area GetLinkTarget(FPDF_LINK link, LinkTarget* target); 105 Area GetLinkTarget(FPDF_LINK link, LinkTarget* target);
106 // Returns target associated with a destination. 106 // Returns target associated with a destination.
107 Area GetDestinationTarget(FPDF_DEST destination, LinkTarget* target); 107 Area GetDestinationTarget(FPDF_DEST destination, LinkTarget* target);
108 // Returns the text in the supplied box as a Value Node 108 // Returns the text in the supplied box as a Value Node
109 base::Value* GetTextBoxAsValue(double page_height, double left, double top, 109 base::Value* GetTextBoxAsValue(double page_height, double left, double top,
110 double right, double bottom, int rotation); 110 double right, double bottom, int rotation);
111 // Helper functions for JSON generation 111 // Helper functions for JSON generation
112 base::Value* CreateTextNode(std::string text); 112 base::Value* CreateTextNode(const std::string& text);
113 base::Value* CreateURLNode(std::string text, std::string url); 113 base::Value* CreateURLNode(const std::string& text, const std::string& url);
114 114
115 class ScopedLoadCounter { 115 class ScopedLoadCounter {
116 public: 116 public:
117 explicit ScopedLoadCounter(PDFiumPage* page); 117 explicit ScopedLoadCounter(PDFiumPage* page);
118 ~ScopedLoadCounter(); 118 ~ScopedLoadCounter();
119 119
120 private: 120 private:
121 PDFiumPage* const page_; 121 PDFiumPage* const page_;
122 }; 122 };
123 123
(...skipping 13 matching lines...) Expand all
137 int loading_count_; 137 int loading_count_;
138 pp::Rect rect_; 138 pp::Rect rect_;
139 bool calculated_links_; 139 bool calculated_links_;
140 std::vector<Link> links_; 140 std::vector<Link> links_;
141 bool available_; 141 bool available_;
142 }; 142 };
143 143
144 } // namespace chrome_pdf 144 } // namespace chrome_pdf
145 145
146 #endif // PDF_PDFIUM_PDFIUM_PAGE_H_ 146 #endif // PDF_PDFIUM_PDFIUM_PAGE_H_
OLDNEW
« no previous file with comments | « no previous file | pdf/pdfium/pdfium_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698