Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 1345393005: Cleanup: Pass std::string as const reference from pdf/ (Closed)

Created:
5 years, 3 months ago by ki.stfu
Modified:
5 years, 3 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Pass std::string as const reference from pdf/ Passing std::string by reference can prevent extra copying of object. BUG=367418 TEST= R=jam@chromium.org,jochen@chromium.org Committed: https://crrev.com/9f9f5da774a8449eb00fe49e4b97916f3d3ed07d Cr-Commit-Position: refs/heads/master@{#350044}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M pdf/pdfium/pdfium_page.h View 1 chunk +2 lines, -2 lines 0 comments Download
M pdf/pdfium/pdfium_page.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
ki.stfu
5 years, 3 months ago (2015-09-20 20:14:49 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-21 15:03:10 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345393005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345393005/1
5 years, 3 months ago (2015-09-21 17:16:14 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_ng/builds/43345)
5 years, 3 months ago (2015-09-21 17:42:11 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345393005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345393005/1
5 years, 3 months ago (2015-09-21 21:14:47 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-21 21:45:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345393005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345393005/1
5 years, 3 months ago (2015-09-21 22:12:22 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 22:20:10 UTC) #13
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 22:21:57 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9f9f5da774a8449eb00fe49e4b97916f3d3ed07d
Cr-Commit-Position: refs/heads/master@{#350044}

Powered by Google App Engine
This is Rietveld 408576698