Move management delegate from base

Move management delegate from base

This change removes the ContextualSearchManagementDelegate from the
ContextualSearchPanelBase in preparation for making the base more
generic. Only two of the many functions in the deleagte were required
in the base and those methods have been made abstract. The delegate
now lives in ContextualSearchPanel.

BUG=521773
Committed: https://crrev.com/11274b03d1087e20207e80a4ca5daade358729df
Cr-Commit-Position: refs/heads/master@{#351401}

[mdjones, 2015-09-22 18:23:08]

mdjones@chromium.org changed reviewers:
+ pedrosimonetti@chromium.org

[mdjones, 2015-09-22 18:23:08]

PTAL

[pedro (no code reviews), 2015-09-25 16:40:24]

lgtm

Matt,

This change is looking good to me, but I think we still need to remove those
dependencies in the near future, which I don't mind being done in a later CL.

The Base might still need some sort of Features class, describing which options
for the UI should be used, but it should not know about CustomTab. We could, for
example, pass a Features instance to the constructor, as a dependency injection.
The height of the top controls could maybe even be part of the Features class.

https://codereview.chromium.org/1345373007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java
(right):

https://codereview.chromium.org/1345373007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java:854:
* @return True if the tab hosting the panel is a custom tab.
Nit: Please put those two methods at the top, where the other abstract methods
are located, in a separate code section named "Generic methods from Contextual
Search Manager". Finally, put a TODO to remove those dependencies entirely.

[mdjones, 2015-09-25 18:07:31]

Agreed, a general features class would be nice but is not a pressing concern at
the moment.

https://codereview.chromium.org/1345373007/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java
(right):

https://codereview.chromium.org/1345373007/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchPanelBase.java:854:
* @return True if the tab hosting the panel is a custom tab.
On 2015/09/25 16:40:24, pedrosimonetti wrote:
> Nit: Please put those two methods at the top, where the other abstract methods
> are located, in a separate code section named "Generic methods from Contextual
> Search Manager". Finally, put a TODO to remove those dependencies entirely.

Done.

[pedro (no code reviews), 2015-09-28 23:29:55]

Latest patch looks good to me.

[mdjones, 2015-09-29 19:56:43]

The CQ bit was checked by mdjones@chromium.org

[mdjones, 2015-09-29 19:56:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
pedrosimonetti@chromium.org
Link to the patchset: https://codereview.chromium.org/1345373007/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2015-09-29 19:57:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1345373007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1345373007/60001

[commit-bot: I haz the power, 2015-09-29 20:12:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-29 20:12:48]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)

[mdjones, 2015-09-29 20:54:14]

The CQ bit was checked by mdjones@chromium.org

[commit-bot: I haz the power, 2015-09-29 20:55:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1345373007/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1345373007/60001

[commit-bot: I haz the power, 2015-09-29 21:13:31]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-09-29 21:14:41]

Patchset 4 (id:??) landed as
https://crrev.com/11274b03d1087e20207e80a4ca5daade358729df
Cr-Commit-Position: refs/heads/master@{#351401}