Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 134533004: Clarify runtime.connect and runtime.sendMessage docs. (Closed)

Created:
6 years, 11 months ago by not at google - send to devlin
Modified:
6 years, 11 months ago
Reviewers:
mkearney1
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : add commas #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M chrome/common/extensions/api/runtime.json View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
not at google - send to devlin
I will certainly need some help to polish this.
6 years, 11 months ago (2014-01-10 20:08:17 UTC) #1
mkearney1
lgtm https://codereview.chromium.org/134533004/diff/1/chrome/common/extensions/api/runtime.json File chrome/common/extensions/api/runtime.json (right): https://codereview.chromium.org/134533004/diff/1/chrome/common/extensions/api/runtime.json#newcode215 chrome/common/extensions/api/runtime.json:215: "description": "Sends a single message to event listeners ...
6 years, 11 months ago (2014-01-13 22:08:43 UTC) #2
not at google - send to devlin
https://codereview.chromium.org/134533004/diff/1/chrome/common/extensions/api/runtime.json File chrome/common/extensions/api/runtime.json (right): https://codereview.chromium.org/134533004/diff/1/chrome/common/extensions/api/runtime.json#newcode215 chrome/common/extensions/api/runtime.json:215: "description": "Sends a single message to event listeners within ...
6 years, 11 months ago (2014-01-16 00:25:41 UTC) #3
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 11 months ago (2014-01-16 00:38:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/134533004/50001
6 years, 11 months ago (2014-01-16 01:28:50 UTC) #5
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) base_unittests, browser_tests, interactive_ui_tests, net_unittests, unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=247043
6 years, 11 months ago (2014-01-16 06:54:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kalman@chromium.org/134533004/50001
6 years, 11 months ago (2014-01-16 17:19:43 UTC) #7
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 19:50:05 UTC) #8
Message was sent while issue was closed.
Change committed as 245292

Powered by Google App Engine
This is Rietveld 408576698