src/hydrogen.cc - Issue 1345313005: [crankshaft] Generalize PropertyAccessInfo to Name (so it can deal with symbols).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 1345313005: [crankshaft] Generalize PropertyAccessInfo to Name (so it can deal with symbols). (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 31c42c74e65ee7475ff990316726c969d36b1607..5ea5776f459014f477fe0bf3fb3ac28dc336342d 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -6409,8 +6409,8 @@ bool HOptimizedGraphBuilder::PropertyAccessInfo::LookupInPrototypes() {

bool HOptimizedGraphBuilder::PropertyAccessInfo::IsIntegerIndexedExotic() {

InstanceType instance_type = map_->instance_type();

- return instance_type == JS_TYPED_ARRAY_TYPE &&

- IsSpecialIndex(isolate()->unicode_cache(), *name_);

+ return instance_type == JS_TYPED_ARRAY_TYPE && name_->IsString() &&

+ IsSpecialIndex(isolate()->unicode_cache(), String::cast(*name_));

}

« no previous file with comments | « src/hydrogen.h ('k') | src/hydrogen-instructions.h » ('j') | no next file with comments »