Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1045)

Issue 1345313005: [crankshaft] Generalize PropertyAccessInfo to Name (so it can deal with symbols). (Closed)

Created:
5 years, 3 months ago by Benedikt Meurer
Modified:
5 years, 3 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[crankshaft] Generalize PropertyAccessInfo to Name (so it can deal with symbols). This doesn't fix the performance regression mentioned by the bug yet, but is necessary cleanup to land the fix, and should be separated from the actual fix. R=jkummerow@chromium.org BUG=chromium:534200 LOG=n Committed: https://crrev.com/704e3d809b071ad3a4a5331a01768a004069a429 Cr-Commit-Position: refs/heads/master@{#30847}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -26 lines) Patch
M src/hydrogen.h View 4 chunks +5 lines, -5 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/hydrogen-instructions.h View 6 chunks +15 lines, -18 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 3 months ago (2015-09-21 12:28:02 UTC) #1
Benedikt Meurer
Hey Jakob, As discussed offline, this is the initial CL for PropertyAccessInfo. The performance regression ...
5 years, 3 months ago (2015-09-21 12:28:41 UTC) #2
Jakob Kummerow
LGTM. About as easy as I was hoping :-)
5 years, 3 months ago (2015-09-21 12:48:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345313005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345313005/1
5 years, 3 months ago (2015-09-21 12:49:19 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-21 12:58:07 UTC) #6
commit-bot: I haz the power
5 years, 3 months ago (2015-09-21 12:58:27 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/704e3d809b071ad3a4a5331a01768a004069a429
Cr-Commit-Position: refs/heads/master@{#30847}

Powered by Google App Engine
This is Rietveld 408576698