Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1345313003: Merge to XFA: Fix a #include in fpdf_page_func.cpp. (Closed)

Created:
5 years, 3 months ago by Lei Zhang
Modified:
5 years, 3 months ago
Reviewers:
David Lattimore
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

Merge to XFA: Fix a #include in fpdf_page_func.cpp. Not sure why building with gyp was working despite the missing '../' but it wasn't working in stricter build systems. TBR=dml@google.com Review URL: https://codereview.chromium.org/1321293003. (cherry picked from commit fa31d9630aadfe101d3b35e26ce0fc926ec1505b) Committed: https://pdfium.googlesource.com/pdfium/+/b2ed5de36ca387e0a9bbc3dfb9f5b568c7cc2ea8

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M core/src/fpdfapi/fpdf_page/fpdf_page_func.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/base/numerics/safe_conversions_impl.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Lei Zhang
TBR, automatic merge.
5 years, 3 months ago (2015-09-17 22:48:20 UTC) #1
Lei Zhang
Committed patchset #1 (id:1) manually as b2ed5de36ca387e0a9bbc3dfb9f5b568c7cc2ea8 (presubmit successful).
5 years, 3 months ago (2015-09-17 22:48:54 UTC) #2
David Lattimore
5 years, 3 months ago (2015-09-17 22:50:57 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698