Issue 1345293002: Don't allow multiple symbol tables in the module block.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1345293002: Don't allow multiple symbol tables in the module block. (Closed)

Created:
5 years, 3 months ago by Karl

Modified:
5 years, 3 months ago

Reviewers:
Jim Stichnoth, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+38 lines, -6 lines)			Patch
M	src/PNaClTranslator.cpp	View	3 chunks	+10 lines, -1 line	0 comments	Download
A +	tests_lit/parse_errs/Inputs/dup-module-vst.tbc	View	1 chunk	+6 lines, -5 lines	0 comments	Download
A	tests_lit/parse_errs/dup-module-vst.test	View	1 chunk	+22 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Karl

5 years, 3 months ago (2015-09-17 17:19:55 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
c49eeae4f33d0048b7099b6756274ae4d61a867e (presubmit successful).