Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: runtime/vm/os_thread_win.cc

Issue 1345273002: Weaken an assert in the message handler (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: remove assert weakening Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/os_thread_win.cc
diff --git a/runtime/vm/os_thread_win.cc b/runtime/vm/os_thread_win.cc
index 7af1ce41d96914a5ef52aff1cecf60ca71efc552..8fd13c94dfb79b1b3f446f66327ebb4ed0aeedc0 100644
--- a/runtime/vm/os_thread_win.cc
+++ b/runtime/vm/os_thread_win.cc
@@ -118,7 +118,6 @@ void OSThread::Join(ThreadJoinId id) {
// Second OSThread could be refactored to no longer be AllStatic. Then the
// handle could be cached in the object by the Start method.
if (handle == NULL) {
- ASSERT(GetLastError() == ERROR_INVALID_PARAMETER);
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698