chrome/browser/resources/settings/appearance_page/appearance_page.html - Issue 1345253002: [MD settings] adding dom-if to hide homepage settings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 1345253002: [MD settings] adding dom-if to hide homepage settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: review changes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/settings/appearance_page/appearance_page.html

diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html

index dbb178eaf562b90fed93bd153b092babe4981842..6bc62a787f965311494a44c5941f1c29c1e98c01 100644

--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html

+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html

@@ -25,16 +25,17 @@

<cr-settings-checkbox pref="{{prefs.browser.show_home_button}}"

i18n-values="label:showHomeButton">

</cr-settings-checkbox>

- <div class="radio-container">

- <paper-radio-group

- hidden="[[!prefs.browser.show_home_button.value]]"

- selected="{{isNewTabPageString_}}">

- <paper-radio-button name="true" i18n-content="homePageNtp">

- </paper-radio-button>

- <paper-radio-button name="false" i18n-content="openThisPage">

- </paper-radio-button>

- </paper-radio-group>

- </div>

+ <template is="dom-if" if="{{prefs.browser.show_home_button.value}}">

+ <div class="radio-container">

+ <paper-radio-group

+ selected="{{isNewTabPageString_}}">

+ <paper-radio-button

+ name="true">[[i18n_.homePageNtp]]</paper-radio-button>

+ <paper-radio-button

+ name="false">[[i18n_.openThisPage]]</paper-radio-button>

+ </paper-radio-group>

+ </div>

+ </template>

<cr-settings-checkbox pref="{{prefs.bookmark_bar.show_on_all_tabs}}"

i18n-values="label:showBookmarksBar">

</cr-settings-checkbox>

« no previous file with comments | « no previous file | chrome/browser/resources/settings/appearance_page/appearance_page.js » ('j') | no next file with comments »