Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5612)

Unified Diff: chrome/browser/resources/settings/appearance_page/appearance_page.html

Issue 1345253002: [MD settings] adding dom-if to hide homepage settings (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: setting upstream branch Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/resources/settings/appearance_page/appearance_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/appearance_page/appearance_page.html
diff --git a/chrome/browser/resources/settings/appearance_page/appearance_page.html b/chrome/browser/resources/settings/appearance_page/appearance_page.html
index 92a704163dea9dabab2f4ff0e3ce6b28fd6e875d..736219727c18770ade73cb51072c54a57e1fbb32 100644
--- a/chrome/browser/resources/settings/appearance_page/appearance_page.html
+++ b/chrome/browser/resources/settings/appearance_page/appearance_page.html
@@ -25,16 +25,17 @@
<cr-settings-checkbox pref="{{prefs.browser.show_home_button}}"
i18n-values="label:showHomeButton">
</cr-settings-checkbox>
+ <template is="dom-if" if="{{prefs.browser.show_home_button.value}}">
Dan Beam 2015/09/16 21:50:13 indent inside the template
dschuyler 2015/09/16 22:06:44 Done.
<div class="radio-container">
<paper-radio-group
- hidden="[[!prefs.browser.show_home_button.value]]"
selected="{{isNewTabPageString}}">
- <paper-radio-button name="t" i18n-content="homePageNtp">
+ <paper-radio-button name="t"><span>[[i18n_.homePageNtp]]</span>
Dan Beam 2015/09/16 21:50:14 why do you need the <span>? <paper-radio-button n
dschuyler 2015/09/16 22:06:43 Thanks, I didn't know it was ok to go over the 80
</paper-radio-button>
- <paper-radio-button name="f" i18n-content="openThisPage">
+ <paper-radio-button name="f"><span>[[i18n_.openThisPage]]</span>
</paper-radio-button>
</paper-radio-group>
</div>
+ </template>
<cr-settings-checkbox pref="{{prefs.bookmark_bar.show_on_all_tabs}}"
i18n-values="label:showBookmarksBar">
</cr-settings-checkbox>
« no previous file with comments | « no previous file | chrome/browser/resources/settings/appearance_page/appearance_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698