Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(164)

Issue 134523007: Fix JID checking for cases where the user account does not have a Google email associated with it. (Closed)

Created:
6 years, 8 months ago by rmsousa
Modified:
6 years, 8 months ago
Reviewers:
Sergey Ulanov
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, weitaosu+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Fix JID checking for cases where the user account does not have a Google email associated with it. BUG=333464 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=244361

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -8 lines) Patch
M remoting/host/remoting_me2me_host.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.h View 3 chunks +3 lines, -0 lines 0 comments Download
M remoting/protocol/me2me_host_authenticator_factory.cc View 5 chunks +26 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
rmsousa
PTAL
6 years, 8 months ago (2014-01-11 00:30:40 UTC) #1
Sergey Ulanov
LGTM. Thanks!
6 years, 8 months ago (2014-01-11 00:42:56 UTC) #2
rmsousa
Tested locally by registering a host using an account in that situation, and successfully connecting ...
6 years, 8 months ago (2014-01-11 00:58:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rmsousa@chromium.org/134523007/1
6 years, 8 months ago (2014-01-11 02:02:03 UTC) #4
commit-bot: I haz the power
6 years, 8 months ago (2014-01-11 22:24:41 UTC) #5
Message was sent while issue was closed.
Change committed as 244361

Powered by Google App Engine
This is Rietveld 408576698