Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1345223005: PPC: Fix AssertFunction. (Closed)

Created:
5 years, 3 months ago by MTBrandyberry
Modified:
5 years, 3 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: Fix AssertFunction. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, dstence@us.ibm.com BUG= Committed: https://crrev.com/5bbd5c58ef5658c05a3b442616f930848bdc0b17 Cr-Commit-Position: refs/heads/master@{#30838}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/ppc/macro-assembler-ppc.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345223005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345223005/1
5 years, 3 months ago (2015-09-18 19:00:26 UTC) #2
dstence
lgtm
5 years, 3 months ago (2015-09-18 19:02:14 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 3 months ago (2015-09-18 19:25:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345223005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345223005/1
5 years, 3 months ago (2015-09-18 19:41:07 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-18 19:42:29 UTC) #8
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 19:42:40 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/5bbd5c58ef5658c05a3b442616f930848bdc0b17
Cr-Commit-Position: refs/heads/master@{#30838}

Powered by Google App Engine
This is Rietveld 408576698