Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Issue 1345223004: Remove trace event overhead reporting feature (Closed)

Created:
5 years, 3 months ago by Xianzhu
Modified:
5 years, 3 months ago
Reviewers:
dsinclair, nduca
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove trace event overhead reporting feature It's hard to make it right and useful. It may be also a source of bugs. Better to keep things simple. Committed: https://crrev.com/b49d6eda590f046695a461334feda2da72c4fc8b Cr-Commit-Position: refs/heads/master@{#349491}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove ThreadLocalEventBuffer::event_count_ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -70 lines) Patch
M base/trace_event/trace_log.cc View 1 11 chunks +2 lines, -70 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
Xianzhu
5 years, 3 months ago (2015-09-16 21:45:01 UTC) #2
dsinclair
https://codereview.chromium.org/1345223004/diff/1/base/trace_event/trace_log.cc File base/trace_event/trace_log.cc (right): https://codereview.chromium.org/1345223004/diff/1/base/trace_event/trace_log.cc#newcode247 base/trace_event/trace_log.cc:247: int event_count_; Can we also remove event_count_?
5 years, 3 months ago (2015-09-17 13:12:28 UTC) #3
Xianzhu
https://codereview.chromium.org/1345223004/diff/1/base/trace_event/trace_log.cc File base/trace_event/trace_log.cc (right): https://codereview.chromium.org/1345223004/diff/1/base/trace_event/trace_log.cc#newcode247 base/trace_event/trace_log.cc:247: int event_count_; On 2015/09/17 13:12:28, dsinclair wrote: > Can ...
5 years, 3 months ago (2015-09-17 16:01:49 UTC) #4
dsinclair
lgtm
5 years, 3 months ago (2015-09-17 16:21:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345223004/20001
5 years, 3 months ago (2015-09-17 16:40:19 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/108731)
5 years, 3 months ago (2015-09-17 17:27:58 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345223004/20001
5 years, 3 months ago (2015-09-17 19:41:51 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345223004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345223004/20001
5 years, 3 months ago (2015-09-17 20:43:59 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 3 months ago (2015-09-17 20:50:09 UTC) #15
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 20:50:45 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/b49d6eda590f046695a461334feda2da72c4fc8b
Cr-Commit-Position: refs/heads/master@{#349491}

Powered by Google App Engine
This is Rietveld 408576698