Add new Dart API call Dart_MakeIsolateRunnable(). This would allow an

Add new Dart API call Dart_MakeIsolateRunnable(). This would allow an
embedder to indicate when an Isolate is runnable and would allow for
asynchronous loading of scripts when an isolate is spawned.

The standalone embedder which does synchronous loading of scripts calls
Dart_MakeIsolateRunnable immediately after it finished loading the scripts
synchronously.

[Ivan Posva, 2013-04-05 04:18:04]

-Ivan

https://codereview.chromium.org/13452007/diff/3002/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/13452007/diff/3002/runtime/include/dart_api.h...
runtime/include/dart_api.h:836: * isolate is complete and the isolate can start
running code.
It is not clear from this description whether the current isolate is exited as
part of this call. The issue is this: As soon as this call is made it is
possible for the thread pool to start dispatching messages. At this point the
thread calling Dart_MakeIsolateRunnable might not have exited the isolate yet.

How about:
bool Dart_IsolateMakeRunnable(Dart_Isolate isolate);

With the precondition being that the isolate is not entered when this call is
made.

[siva, 2013-04-05 07:04:05]

Changed API to include an isolate parameter and added check to ensure there is
no current isolate when this function is called.

[Ivan Posva, 2013-04-05 15:51:59]

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/bin/main.c...
runtime/bin/main.cc:483: Dart_ExitIsolate();
If this method was changed to return the isolate instead of a bool then we would
have to have this dance of setting the isolate back as an implicit return value.

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/include/da...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/include/da...
runtime/include/dart_api.h:841: DART_EXPORT bool
Dart_MakeIsolateRunnable(Dart_Isolate isolate);
Dart_IsolateMakeRunnable. We have tried to follow the Dart_XYZObjectDoSomething
format for most of the API calls, where the first parameter is a XYZObject. I
know that the ones like Dart_InterruptIsolate do not follow that pattern, and we
should clean them up eventually.

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/lib/isolat...
File runtime/lib/isolate.cc (right):

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/lib/isolat...
runtime/lib/isolate.cc:189: ASSERT(child_isolate);
!= NULL

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/lib/isolat...
runtime/lib/isolate.cc:192: // Attempt to resolve the entry function now, so
that we fail fast
This code should not be here.

[siva, 2013-04-05 17:43:29]

Anton, this CL now has an API change. Please review it.

It would require some co-ordination with you in order to land it. I am on
vacation next week, please co-ordinate with Ivan to land this CL.   Thanks.

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/bin/main.cc
File runtime/bin/main.cc (right):

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/bin/main.c...
runtime/bin/main.cc:483: Dart_ExitIsolate();
On 2013/04/05 15:51:59, Ivan Posva wrote:
> If this method was changed to return the isolate instead of a bool then we
would
> have to have this dance of setting the isolate back as an implicit return
value.

Done.

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/include/da...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/include/da...
runtime/include/dart_api.h:841: DART_EXPORT bool
Dart_MakeIsolateRunnable(Dart_Isolate isolate);
On 2013/04/05 15:51:59, Ivan Posva wrote:
> Dart_IsolateMakeRunnable. We have tried to follow the
Dart_XYZObjectDoSomething
> format for most of the API calls, where the first parameter is a XYZObject. I
> know that the ones like Dart_InterruptIsolate do not follow that pattern, and
we
> should clean them up eventually.

Done.

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/lib/isolat...
File runtime/lib/isolate.cc (right):

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/lib/isolat...
runtime/lib/isolate.cc:189: ASSERT(child_isolate);
On 2013/04/05 15:51:59, Ivan Posva wrote:
> != NULL

Done.

https://chromiumcodereview.appspot.com/13452007/diff/21001/runtime/lib/isolat...
runtime/lib/isolate.cc:192: // Attempt to resolve the entry function now, so
that we fail fast
Removed this code and moved the unhandled exception handler setting to
RunIsolate.

On 2013/04/05 15:51:59, Ivan Posva wrote:
> This code should not be here.

[Anton Muhin, 2013-04-08 15:20:17]

https://chromiumcodereview.appspot.com/13452007/diff/46001/runtime/include/da...
File runtime/include/dart_api.h (right):

https://chromiumcodereview.appspot.com/13452007/diff/46001/runtime/include/da...
runtime/include/dart_api.h:597: * \return The embedder returns false if the
creation and
nit: this doc is not correct any more.

https://chromiumcodereview.appspot.com/13452007/diff/46001/runtime/include/da...
runtime/include/dart_api.h:843: DART_EXPORT bool
Dart_IsolateMakeRunnable(Dart_Isolate isolate);
any restriction on thread affinity?

[Ivan Posva, 2013-04-09 17:38:55]

Created https://codereview.chromium.org/13813018 to land this change in sync
with Anton and addressed review comment there.

-Ivan

https://codereview.chromium.org/13452007/diff/46001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/13452007/diff/46001/runtime/include/dart_api....
runtime/include/dart_api.h:597: * \return The embedder returns false if the
creation and
On 2013/04/08 15:20:17, Anton Muhin wrote:
> nit: this doc is not correct any more.

Done.

https://codereview.chromium.org/13452007/diff/46001/runtime/include/dart_api....
runtime/include/dart_api.h:843: DART_EXPORT bool
Dart_IsolateMakeRunnable(Dart_Isolate isolate);
On 2013/04/08 15:20:17, Anton Muhin wrote:
> any restriction on thread affinity? 

Not sure I understand the question, but this will tell the VM that the VM
internal thread pool is allowed to pickup the isolate and start dispatching
events. If this call is made from within the Dart_IsolateCreateCallback, then
dispatching starts once the callback returns.

[Anton Muhin, 2013-04-09 17:45:12]

https://codereview.chromium.org/13452007/diff/46001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/13452007/diff/46001/runtime/include/dart_api....
runtime/include/dart_api.h:843: DART_EXPORT bool
Dart_IsolateMakeRunnable(Dart_Isolate isolate);
Sorry for not being clear, I was curious if there are any restrictions for the
thread on which I can invoke this method?

Must it be a thread on which the isolate callback has been invoked on any other
thread?

Overall, are there any restrictions on the thread from which I can load the
source of the isolate?

On 2013/04/09 17:38:55, Ivan Posva wrote:
> On 2013/04/08 15:20:17, Anton Muhin wrote:
> > any restriction on thread affinity? 
> 
> Not sure I understand the question, but this will tell the VM that the VM
> internal thread pool is allowed to pickup the isolate and start dispatching
> events. If this call is made from within the Dart_IsolateCreateCallback, then
> dispatching starts once the callback returns.

[Ivan Posva, 2013-04-09 18:19:47]

The linked changelist https://codereview.chromium.org/13813018 was committed as:
https://code.google.com/p/dart/source/detail?r=21160

-Ivan

https://codereview.chromium.org/13452007/diff/46001/runtime/include/dart_api.h
File runtime/include/dart_api.h (right):

https://codereview.chromium.org/13452007/diff/46001/runtime/include/dart_api....
runtime/include/dart_api.h:843: DART_EXPORT bool
Dart_IsolateMakeRunnable(Dart_Isolate isolate);
On 2013/04/09 17:45:12, Anton Muhin wrote:
> Sorry for not being clear, I was curious if there are any restrictions for the
> thread on which I can invoke this method?
> 
> Must it be a thread on which the isolate callback has been invoked on any
other
> thread?

The Dart_IsolateMakeRunnable should be callable on any thread. As the
documentation says, you do not have to enter any isolate to make that call.

> Overall, are there any restrictions on the thread from which I can load the
> source of the isolate?

To load sources into an isolate you need to enter that isolate on the thread
calling Dart_LoadLibrary and friends. This is only possible once you have exited
the newly created isolate from within the callback.

> On 2013/04/09 17:38:55, Ivan Posva wrote:
> > On 2013/04/08 15:20:17, Anton Muhin wrote:
> > > any restriction on thread affinity? 
> > 
> > Not sure I understand the question, but this will tell the VM that the VM
> > internal thread pool is allowed to pickup the isolate and start dispatching
> > events. If this call is made from within the Dart_IsolateCreateCallback,
then
> > dispatching starts once the callback returns.
>