chrome/browser/extensions/api/streams_private/streams_private_api.cc - Issue 13452002: Update manifest file for Quickoffice component extension

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/streams_private/streams_private_api.cc

Issue 13452002: Update manifest file for Quickoffice component extension (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix crash due to arguments evaluation order in StreamsPrivateAPI::ExecuteMimeTypeHandler Created 7 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/streams_private/streams_private_api.cc

diff --git a/chrome/browser/extensions/api/streams_private/streams_private_api.cc b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

index 1018b72455bd2c632accdd6eb8a66ed9728c4c77..f2d5ae5cdb62a45df58e8befeb0b2b3d1506275c 100644

--- a/chrome/browser/extensions/api/streams_private/streams_private_api.cc

+++ b/chrome/browser/extensions/api/streams_private/streams_private_api.cc

@@ -60,8 +60,8 @@ void StreamsPrivateAPI::ExecuteMimeTypeHandler(

ExtensionSystem::Get(profile_)->event_router()->DispatchEventToExtension(

extension_id, event.Pass());

- streams_[extension_id][stream->GetURL()] =

- make_linked_ptr(stream.release());

+ GURL url = stream->GetURL();

+ streams_[extension_id][url] = make_linked_ptr(stream.release());

}

static base::LazyInstance<ProfileKeyedAPIFactory<StreamsPrivateAPI> >

« no previous file with comments | « no previous file | chrome/browser/resources/quick_office/OWNERS » ('j') | chrome/browser/resources/quick_office/manifest.json » ('J')