Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13452002: Update manifest file for Quickoffice component extension (Closed)

Created:
7 years, 8 months ago by Dmitry Polukhin
Modified:
7 years, 8 months ago
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Update manifest file for Quickoffice component extension BUG=225407 TEST=manual + pyauto Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192053

Patch Set 1 #

Patch Set 2 : Added OWNERS file #

Patch Set 3 : Added to mime type handlers whitelist #

Patch Set 4 : Fix crash due to arguments evaluation order in StreamsPrivateAPI::ExecuteMimeTypeHandler #

Total comments: 4

Patch Set 5 : Removed transient #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -30 lines) Patch
M chrome/browser/extensions/api/streams_private/streams_private_api.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
A + chrome/browser/resources/quick_office/OWNERS View 1 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/quick_office/manifest.json View 1 2 3 4 1 chunk +56 lines, -25 lines 0 comments Download
M chrome/common/extensions/mime_types_handler.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
Dmitry Polukhin
jhawkins@ please do owner review in chrome/browser/resources/*
7 years, 8 months ago (2013-04-02 08:24:13 UTC) #1
Nikita (slow)
lgtm
7 years, 8 months ago (2013-04-02 09:44:53 UTC) #2
Dmitry Polukhin
+ mpcomplete@ for owner review in chrome/common/extensions/* + zork@ FYI
7 years, 8 months ago (2013-04-02 14:38:05 UTC) #3
James Hawkins
lgtm
7 years, 8 months ago (2013-04-02 16:04:27 UTC) #4
Zachary Kuznia
lgtm
7 years, 8 months ago (2013-04-03 04:34:43 UTC) #5
Dmitry Polukhin
+ finnur@ for owner review in extensions, it is very short and simple patch please ...
7 years, 8 months ago (2013-04-03 05:17:56 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/13452002/6002
7 years, 8 months ago (2013-04-03 09:33:50 UTC) #7
Finnur
LGTM, with two comments. https://codereview.chromium.org/13452002/diff/6002/chrome/browser/resources/quick_office/manifest.json File chrome/browser/resources/quick_office/manifest.json (right): https://codereview.chromium.org/13452002/diff/6002/chrome/browser/resources/quick_office/manifest.json#newcode13 chrome/browser/resources/quick_office/manifest.json:13: "transient": true, Transient isn't a ...
7 years, 8 months ago (2013-04-03 11:02:11 UTC) #8
Dmitry Polukhin
https://codereview.chromium.org/13452002/diff/6002/chrome/browser/resources/quick_office/manifest.json File chrome/browser/resources/quick_office/manifest.json (right): https://codereview.chromium.org/13452002/diff/6002/chrome/browser/resources/quick_office/manifest.json#newcode13 chrome/browser/resources/quick_office/manifest.json:13: "transient": true, On 2013/04/03 11:02:11, Finnur wrote: > Transient ...
7 years, 8 months ago (2013-04-03 12:06:09 UTC) #9
Dmitry Polukhin
7 years, 8 months ago (2013-04-03 12:10:46 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 manually as r192053 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698