Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1345193004: Add WebNode::isCommentNode(). (Closed)

Created:
5 years, 3 months ago by esprehn
Modified:
5 years, 3 months ago
Reviewers:
pdr., dglazkov
CC:
blink-reviews, dglazkov+blink
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add WebNode::isCommentNode(). This will let us remove WebNode::nodeType() and the associated enum. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202499

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/web/WebNode.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebNode.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
esprehn
5 years, 3 months ago (2015-09-17 23:25:21 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345193004/1
5 years, 3 months ago (2015-09-17 23:25:34 UTC) #4
pdr.
LGTM Can we group some of these changes together instead of doing them one-by-one?
5 years, 3 months ago (2015-09-17 23:26:09 UTC) #5
esprehn
On 2015/09/17 at 23:26:09, pdr wrote: > LGTM > > Can we group some of ...
5 years, 3 months ago (2015-09-17 23:32:35 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/70647)
5 years, 3 months ago (2015-09-18 02:12:24 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345193004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345193004/1
5 years, 3 months ago (2015-09-18 02:30:39 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-18 03:34:33 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202499

Powered by Google App Engine
This is Rietveld 408576698