CrOS: Use local Chromite checkout for configs.

CrOS: Use local Chromite checkout for configs.

Instead of loading configs from "cros_chromite" build module, use the
local Chromite checkout.

BUG=chromium:533176
TEST=expectations

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=296936

[dnj (Google), 2015-09-18 02:03:21]

Patchset #1 (id:1) has been deleted

[dnj (Google), 2015-09-25 14:50:39]

dnj@google.com changed reviewers:
+ dnj@google.com, iannucci@chromium.org, luqui@chromium.org

[dnj (Google), 2015-09-25 14:50:39]

PTAL! Looks like this fell off my radar last week.

Will rebase soon to remove the recipe version bump, as that happened elsewhere.

[dnj, 2015-09-29 18:53:38]

(ping)

[iannucci, 2015-09-29 19:17:30]

lgtm

https://codereview.chromium.org/1345143004/diff/40001/infra/config/recipes.cfg
File infra/config/recipes.cfg (right):

https://codereview.chromium.org/1345143004/diff/40001/infra/config/recipes.cf...
infra/config/recipes.cfg:8: revision: "d4e143cac58ee880b72b788ba37f3e06cd4e1668"
this should probably be done in a separate CL? Or at least have a comment (in
rietveld) saying why the roll is necessary.

https://codereview.chromium.org/1345143004/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromite/api.py (right):

https://codereview.chromium.org/1345143004/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromite/api.py:35: return {k: self.get(k) for k in
all_keys}
hm... this seems potentially much less efficient than just

ret = {}
for l in self.layers:
  ret.update(l)
return ret

?

https://codereview.chromium.org/1345143004/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromite/api.py:80: self._cached_config =
step_result.json.output
ugh, really? json.read should be changed to return the actual decoded json data.
grumble.

[dnj, 2015-09-29 19:28:40]

Thanks!

https://codereview.chromium.org/1345143004/diff/40001/infra/config/recipes.cfg
File infra/config/recipes.cfg (right):

https://codereview.chromium.org/1345143004/diff/40001/infra/config/recipes.cf...
infra/config/recipes.cfg:8: revision: "d4e143cac58ee880b72b788ba37f3e06cd4e1668"
On 2015/09/29 19:17:30, iannucci wrote:
> this should probably be done in a separate CL? Or at least have a comment (in
> rietveld) saying why the roll is necessary.

I think this roll is actually obsolete, but if it is necessary will do.

https://codereview.chromium.org/1345143004/diff/40001/scripts/slave/recipe_mo...
File scripts/slave/recipe_modules/chromite/api.py (right):

https://codereview.chromium.org/1345143004/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromite/api.py:35: return {k: self.get(k) for k in
all_keys}
On 2015/09/29 19:17:30, iannucci wrote:
> hm... this seems potentially much less efficient than just
> 
> ret = {}
> for l in self.layers:
>   ret.update(l)
> return ret
> 
> ?

Done.

https://codereview.chromium.org/1345143004/diff/40001/scripts/slave/recipe_mo...
scripts/slave/recipe_modules/chromite/api.py:80: self._cached_config =
step_result.json.output
On 2015/09/29 19:17:30, iannucci wrote:
> ugh, really? json.read should be changed to return the actual decoded json
data.
> grumble.

Acknowledged.

[dnj, 2015-09-29 19:34:51]

The CQ bit was checked by dnj@chromium.org

[dnj, 2015-09-29 19:34:52]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/1345143004/#ps60001
(title: "Rebased, comments, more useful expectations.")

[commit-bot: I haz the power, 2015-09-29 19:35:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1345143004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1345143004/60001

[commit-bot: I haz the power, 2015-09-29 19:38:34]

Committed patchset #3 (id:60001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=296936