tools/dom/src/dart2js_DOMImplementation.dart - Issue 1345083002: Revert "Dartium JS Interop enabled."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/dom/src/dart2js_DOMImplementation.dart

Issue 1345083002: Revert "Dartium JS Interop enabled." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/dom/src/dart2js_DOMImplementation.dart

diff --git a/tools/dom/src/dart2js_DOMImplementation.dart b/tools/dom/src/dart2js_DOMImplementation.dart

index 24e6a6cd569e3ca79411e4b7bbcb870be887e2c3..dd82ad8e9afa939ab431c07c0f3e620348c9a6ca 100644

--- a/tools/dom/src/dart2js_DOMImplementation.dart

+++ b/tools/dom/src/dart2js_DOMImplementation.dart

@@ -83,7 +83,7 @@ class _LocationCrossFrame implements LocationBase {

// properly. Its fields and methods can only be accessed via JavaScript.

var _location;

- set href(String val) => _setHref(_location, val);

+ void set href(String val) => _setHref(_location, val);

static void _setHref(location, val) {

JS('void', '#.href = #', location, val);

}

« no previous file with comments | « tools/dom/src/_chrome/utils.dart ('k') | tools/dom/src/dartium_KeyEvent.dart » ('j') | no next file with comments »