Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1262)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java

Issue 1345043002: Update access info when an offline page is being visited (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Some more fixes Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
index 3f258249d716a1bfca0f19141ccbb319b454ded5..bbe2d6f4ab5777325d1ce63b37f1bb411dafb90c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
@@ -226,19 +226,25 @@ public class EnhancedBookmarksModel extends BookmarksBridge {
}
/**
- * Returns the url used to launch a bookmark.
+ * Retrieves the url to launch a bookmark or saved page. If latter, also marks it as being
+ * accessed.
*
* @param bookmarkId ID of the bookmark to launch.
+ * @return The launch URL.
*/
- public String getBookmarkLaunchUrl(BookmarkId bookmarkId) {
+ public String getLaunchUrlAndMarkAccessed(BookmarkId bookmarkId) {
String url = getBookmarkById(bookmarkId).getUrl();
- if (mOfflinePageBridge == null) {
- return url;
- }
+ if (mOfflinePageBridge == null) return url;
// Return the offline url for the offline page.
OfflinePageItem page = mOfflinePageBridge.getPageByBookmarkId(bookmarkId);
- return page == null ? url : page.getOfflineUrl();
+ if (page == null) return url;
+
+ // Mark that the offline page has been accessed, that will cause last access time and access
+ // count being updated.
+ mOfflinePageBridge.markPageAccessed(bookmarkId);
+
+ return page.getOfflineUrl();
}
/**

Powered by Google App Engine
This is Rietveld 408576698