Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(590)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java

Issue 1345043002: Update access info when an offline page is being visited (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address more feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
index c08c46e13f74acd908c3d8f1e74735869da76104..23a8865b16209ae4e7e53187fd1d3e7be19357df 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarkManager.java
@@ -11,6 +11,7 @@ import android.preference.PreferenceManager;
import android.support.v4.widget.DrawerLayout;
import android.text.TextUtils;
import android.util.Log;
+import android.util.Pair;
import android.view.Gravity;
import android.view.View;
import android.view.ViewGroup;
@@ -414,10 +415,17 @@ public class EnhancedBookmarkManager implements EnhancedBookmarkDelegate {
public void openBookmark(BookmarkId bookmark, int launchLocation) {
clearSelection();
if (mEnhancedBookmarksModel.getBookmarkById(bookmark) != null) {
- String url = mEnhancedBookmarksModel.getBookmarkLaunchUrl(bookmark);
+ Pair<String, Boolean> urlAndFlagPair =
+ mEnhancedBookmarksModel.getBookmarkLaunchUrl(bookmark);
+ String url = urlAndFlagPair.first;
// TODO(jianli): Notify the user about the failure.
if (TextUtils.isEmpty(url)) return;
+ boolean isOfflinePageURL = urlAndFlagPair.second;
+ if (isOfflinePageURL) {
+ mEnhancedBookmarksModel.markOfflinePageAccessed(bookmark);
+ }
+
NewTabPageUma.recordAction(NewTabPageUma.ACTION_OPENED_BOOKMARK);
RecordHistogram.recordEnumeratedHistogram("Stars.LaunchLocation", launchLocation,
LaunchLocation.COUNT);

Powered by Google App Engine
This is Rietveld 408576698