Update access info when an offline page is being visited

chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java

Index: chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
index 3f258249d716a1bfca0f19141ccbb319b454ded5..71e9efab61539cb718d1ea3f57f3623fbdeece9c 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/enhancedbookmarks/EnhancedBookmarksModel.java
@@ -232,13 +232,17 @@ public class EnhancedBookmarksModel extends BookmarksBridge {
      */
     public String getBookmarkLaunchUrl(BookmarkId bookmarkId) {

[newt (away), 2015/09/21 23:02:05]

Eek. I never want to program against an API where getter methods have
side-effects. This seems very prone to breakage (e.g. access counts being
updated twice).

See "Misleading names" in this wonderful document:
http://www.se.rit.edu/~tabeec/RIT_441/Resources_files/How%20To%20Write%20Unma...

Either rename this method to make it clear that it has side-effects, or split
this into two separate methods.

[jianli, 2015/09/23 00:11:11]

Split into 2 methods.

         String url = getBookmarkById(bookmarkId).getUrl();
-        if (mOfflinePageBridge == null) {
-            return url;
-        }
+        if (mOfflinePageBridge == null) return url;
 
         // Return the offline url for the offline page.
         OfflinePageItem page = mOfflinePageBridge.getPageByBookmarkId(bookmarkId);
-        return page == null ? url : page.getOfflineUrl();
+        if (page == null) return url;
+
+        // Mark that the offline page has been accessed, that will cause last access time and access
+        // count being updated.
+        mOfflinePageBridge.markPageAccessed(bookmarkId);
+
+        return page.getOfflineUrl();
     }
 
     /**