Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(178)

Side by Side Diff: components/offline_pages/offline_page_model.cc

Issue 1345043002: Update access info when an offline page is being visited (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address some more feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/offline_page_model.h" 5 #include "components/offline_pages/offline_page_model.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
105 scoped_ptr<OfflinePageArchiver> archiver, 105 scoped_ptr<OfflinePageArchiver> archiver,
106 const SavePageCallback& callback) { 106 const SavePageCallback& callback) {
107 DCHECK(is_loaded_); 107 DCHECK(is_loaded_);
108 DCHECK(archiver.get()); 108 DCHECK(archiver.get());
109 archiver->CreateArchive(base::Bind(&OfflinePageModel::OnCreateArchiveDone, 109 archiver->CreateArchive(base::Bind(&OfflinePageModel::OnCreateArchiveDone,
110 weak_ptr_factory_.GetWeakPtr(), url, 110 weak_ptr_factory_.GetWeakPtr(), url,
111 bookmark_id, callback)); 111 bookmark_id, callback));
112 pending_archivers_.push_back(archiver.Pass()); 112 pending_archivers_.push_back(archiver.Pass());
113 } 113 }
114 114
115 void OfflinePageModel::MarkPageAccessed(
116 int64 bookmark_id,
117 const MarkPageAccessedCallback& callback) {
118 DCHECK(is_loaded_);
119 auto iter = offline_pages_.find(bookmark_id);
120 if (iter == offline_pages_.end())
121 return;
122
123 iter->second.last_access_time = base::Time::Now();
124 iter->second.access_count++;
125 store_->AddOrUpdateOfflinePage(
126 iter->second,
127 base::Bind(&OfflinePageModel::OnUpdateOfflinePageDone,
128 weak_ptr_factory_.GetWeakPtr(), callback));
129 }
130
115 void OfflinePageModel::DeletePageByBookmarkId( 131 void OfflinePageModel::DeletePageByBookmarkId(
116 int64 bookmark_id, 132 int64 bookmark_id,
117 const DeletePageCallback& callback) { 133 const DeletePageCallback& callback) {
118 DCHECK(is_loaded_); 134 DCHECK(is_loaded_);
119 std::vector<int64> bookmark_ids_to_delete; 135 std::vector<int64> bookmark_ids_to_delete;
120 bookmark_ids_to_delete.push_back(bookmark_id); 136 bookmark_ids_to_delete.push_back(bookmark_id);
121 DeletePagesByBookmarkId(bookmark_ids_to_delete, callback); 137 DeletePagesByBookmarkId(bookmark_ids_to_delete, callback);
122 } 138 }
123 139
124 void OfflinePageModel::DeletePagesByBookmarkId( 140 void OfflinePageModel::DeletePagesByBookmarkId(
(...skipping 84 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 225
210 if (archiver_result != ArchiverResult::SUCCESSFULLY_CREATED) { 226 if (archiver_result != ArchiverResult::SUCCESSFULLY_CREATED) {
211 SavePageResult result = ToSavePageResult(archiver_result); 227 SavePageResult result = ToSavePageResult(archiver_result);
212 InformSavePageDone(callback, result); 228 InformSavePageDone(callback, result);
213 DeletePendingArchiver(archiver); 229 DeletePendingArchiver(archiver);
214 return; 230 return;
215 } 231 }
216 232
217 OfflinePageItem offline_page_item(url, bookmark_id, file_path, file_size, 233 OfflinePageItem offline_page_item(url, bookmark_id, file_path, file_size,
218 base::Time::Now()); 234 base::Time::Now());
219 store_->AddOfflinePage( 235 store_->AddOrUpdateOfflinePage(
220 offline_page_item, 236 offline_page_item,
221 base::Bind(&OfflinePageModel::OnAddOfflinePageDone, 237 base::Bind(&OfflinePageModel::OnAddOfflinePageDone,
222 weak_ptr_factory_.GetWeakPtr(), archiver, callback, 238 weak_ptr_factory_.GetWeakPtr(), archiver, callback,
223 offline_page_item)); 239 offline_page_item));
224 } 240 }
225 241
226 void OfflinePageModel::OnAddOfflinePageDone(OfflinePageArchiver* archiver, 242 void OfflinePageModel::OnAddOfflinePageDone(OfflinePageArchiver* archiver,
227 const SavePageCallback& callback, 243 const SavePageCallback& callback,
228 const OfflinePageItem& offline_page, 244 const OfflinePageItem& offline_page,
229 bool success) { 245 bool success) {
230 SavePageResult result; 246 SavePageResult result;
231 if (success) { 247 if (success) {
232 offline_pages_[offline_page.bookmark_id] = offline_page; 248 offline_pages_[offline_page.bookmark_id] = offline_page;
233 result = SavePageResult::SUCCESS; 249 result = SavePageResult::SUCCESS;
234 UMA_HISTOGRAM_MEMORY_KB( 250 UMA_HISTOGRAM_MEMORY_KB(
235 "OfflinePages.PageSize", offline_page.file_size / 1024); 251 "OfflinePages.PageSize", offline_page.file_size / 1024);
236 } else { 252 } else {
237 result = SavePageResult::STORE_FAILURE; 253 result = SavePageResult::STORE_FAILURE;
238 } 254 }
239 InformSavePageDone(callback, result); 255 InformSavePageDone(callback, result);
240 DeletePendingArchiver(archiver); 256 DeletePendingArchiver(archiver);
241 } 257 }
242 258
259 void OfflinePageModel::OnUpdateOfflinePageDone(
260 const MarkPageAccessedCallback& callback, bool success) {
261 callback.Run(success);
262 }
263
243 void OfflinePageModel::BookmarkModelChanged() { 264 void OfflinePageModel::BookmarkModelChanged() {
244 } 265 }
245 266
246 void OfflinePageModel::BookmarkNodeRemoved( 267 void OfflinePageModel::BookmarkNodeRemoved(
247 bookmarks::BookmarkModel* model, 268 bookmarks::BookmarkModel* model,
248 const bookmarks::BookmarkNode* parent, 269 const bookmarks::BookmarkNode* parent,
249 int old_index, 270 int old_index,
250 const bookmarks::BookmarkNode* node, 271 const bookmarks::BookmarkNode* node,
251 const std::set<GURL>& removed_urls) { 272 const std::set<GURL>& removed_urls) {
252 if (!is_loaded_) { 273 if (!is_loaded_) {
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
338 void OfflinePageModel::InformDeletePageDone(const DeletePageCallback& callback, 359 void OfflinePageModel::InformDeletePageDone(const DeletePageCallback& callback,
339 DeletePageResult result) { 360 DeletePageResult result) {
340 UMA_HISTOGRAM_ENUMERATION( 361 UMA_HISTOGRAM_ENUMERATION(
341 "OfflinePages.DeletePageResult", 362 "OfflinePages.DeletePageResult",
342 static_cast<int>(result), 363 static_cast<int>(result),
343 static_cast<int>(DeletePageResult::RESULT_COUNT)); 364 static_cast<int>(DeletePageResult::RESULT_COUNT));
344 callback.Run(result); 365 callback.Run(result);
345 } 366 }
346 367
347 } // namespace offline_pages 368 } // namespace offline_pages
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698