Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1345023002: Expose WebPageImportanceSignals to embedder (Closed)

Created:
5 years, 3 months ago by kouhei (in TOK)
Modified:
5 years, 3 months ago
Reviewers:
*tkent, haraken, tzik
CC:
blink-reviews, dglazkov+blink, Georges Khalil
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose WebPageImportanceSignals to embedder This CL exposes WebPageImportanceSignals to embedder (Chromium content). We plan to have Chromium tab discarding logic make decisions based on this. BUG=520838 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=202436

Patch Set 1 #

Total comments: 2

Patch Set 2 : issue pageImportanceSignalsUpdated from itself #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -6 lines) Patch
M Source/web/ChromeClientImpl.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPageImportanceSignals.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M Source/web/WebViewImpl.h View 2 chunks +1 line, -2 lines 0 comments Download
M Source/web/WebViewImpl.cpp View 1 3 chunks +8 lines, -1 line 0 comments Download
M public/web/WebPageImportanceSignals.h View 1 2 chunks +6 lines, -1 line 0 comments Download
M public/web/WebView.h View 3 chunks +5 lines, -1 line 0 comments Download
M public/web/WebViewClient.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
kouhei (in TOK)
5 years, 3 months ago (2015-09-15 22:59:21 UTC) #2
kouhei (in TOK)
Chromium side: https://codereview.chromium.org/1345873003/
5 years, 3 months ago (2015-09-15 23:09:33 UTC) #4
tkent
https://codereview.chromium.org/1345023002/diff/1/Source/web/ChromeClientImpl.cpp File Source/web/ChromeClientImpl.cpp (right): https://codereview.chromium.org/1345023002/diff/1/Source/web/ChromeClientImpl.cpp#newcode938 Source/web/ChromeClientImpl.cpp:938: m_webView->client()->pageImportanceSignalsChanged(); Can we move the pageImportanceSignalsChanged call into setHadFormInteraction? ...
5 years, 3 months ago (2015-09-15 23:16:42 UTC) #5
kouhei (in TOK)
On 2015/09/15 23:16:42, tkent wrote: > https://codereview.chromium.org/1345023002/diff/1/Source/web/ChromeClientImpl.cpp > File Source/web/ChromeClientImpl.cpp (right): > > https://codereview.chromium.org/1345023002/diff/1/Source/web/ChromeClientImpl.cpp#newcode938 > ...
5 years, 3 months ago (2015-09-16 17:40:07 UTC) #6
tkent
lgtm
5 years, 3 months ago (2015-09-17 07:19:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1345023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1345023002/20001
5 years, 3 months ago (2015-09-17 07:20:06 UTC) #9
haraken
LGTM
5 years, 3 months ago (2015-09-17 07:49:03 UTC) #10
commit-bot: I haz the power
5 years, 3 months ago (2015-09-17 08:34:17 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=202436

Powered by Google App Engine
This is Rietveld 408576698