Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: chromecast/build/args.gn

Issue 1345013002: Add is_chromecast to GN build. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Clean up Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/build/args.gn
diff --git a/chromecast/build/args.gn b/chromecast/build/args.gn
index a768a59b23605aaf4d4394eade1ab6553664de65..688c5bddb946235efe02acba987f4ae5f50f47de 100644
--- a/chromecast/build/args.gn
+++ b/chromecast/build/args.gn
@@ -1,36 +1,12 @@
-# Build arguments for Chromecast.
-# Copy the contents of this file to gn args.
+# Copyright 2015 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
-root_extra_deps = [ "//chromecast" ]
-
-# Enable the use of browser-side CDM.
-enable_browser_cdms = true
-
-# Enable plugins, but explicitly disable use of Pepper CDMs.
-enable_plugins = true
-enable_pepper_cdms = false
-
-# Flags set from build/common.gypi
+# Note: This file is being deprecated. Do not add new args here (b/23601081).
-# Compile with MSE support for MPEG2 TS. See //media/media_options.gni for more
-# detail.
-enable_mpeg2ts_stream_parser = true
-
-# Instead of maintaining a separate "Chromecast" ffmpeg branding, "ChromeOS" is
-# used, as it sufficiently covers all the required codecs.
-ffmpeg_branding = "ChromeOS"
-
-# Setting this to true generates libeglplatform_shim.so.1 from
-# //ui/ozone/platform/egltest:egl_platform_x11.
-ozone_platform_ozonex = true
-
-# Chromecast must use proprietary codecs. Setting this to true defines the
-# USE_PROPRIETARY_CODECS macro and the proper EME_CODEC macros.
-proprietary_codecs = true
+# TODO(slan): Include the chromecast build tree as a dependency at root when
+# the GN build is stable.
+root_extra_deps = [ "//chromecast" ]
-# See //build/config/ui.gni. Notice that use_x11 = is_linux && !use_ozone.
-use_ozone = true
-# TODO(halliwell): look into supporting Cast Ozone with GN.
-# ozone_platform_cast = 1
-# TODO(gyp): Add support for blink_logging_always_on and enable it.
-# blink_logging_always_on = 1
+is_chromecast_build = true
+chromecast_branding = "public"

Powered by Google App Engine
This is Rietveld 408576698