src/preparser.cc - Issue 13450007: Refactor parser mode configuration for correctness

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/preparser.cc

Issue 13450007: Refactor parser mode configuration for correctness (Closed) Base URL: git://github.com/v8/v8.git@master

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/preparser.cc

diff --git a/src/preparser.cc b/src/preparser.cc

index c61a08db9a9985a7165c9bde0fc4b92d89192457..6e8800e019aeafca8434af95a0c47e52e56202f2 100644

--- a/src/preparser.cc

+++ b/src/preparser.cc

@@ -179,7 +179,7 @@ PreParser::SourceElements PreParser::ParseSourceElements(int end_token,

Statement statement = ParseSourceElement(CHECK_OK);

if (allow_directive_prologue) {

if (statement.IsUseStrictLiteral()) {

- set_language_mode(harmony_scoping_ ?

+ set_language_mode(allow_harmony_scoping() ?

i::EXTENDED_MODE : i::STRICT_MODE);

} else if (!statement.IsStringLiteral()) {

allow_directive_prologue = false;