Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: src/liveedit.cc

Issue 13450007: Refactor parser mode configuration for correctness (Closed) Base URL: git://github.com/v8/v8.git@master
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/hydrogen.cc ('k') | src/parser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 591 matching lines...) Expand 10 before | Expand all | Expand 10 after
602 602
603 603
604 static void CompileScriptForTracker(Isolate* isolate, Handle<Script> script) { 604 static void CompileScriptForTracker(Isolate* isolate, Handle<Script> script) {
605 // TODO(635): support extensions. 605 // TODO(635): support extensions.
606 PostponeInterruptsScope postpone(isolate); 606 PostponeInterruptsScope postpone(isolate);
607 607
608 // Build AST. 608 // Build AST.
609 CompilationInfoWithZone info(script); 609 CompilationInfoWithZone info(script);
610 info.MarkAsGlobal(); 610 info.MarkAsGlobal();
611 // Parse and don't allow skipping lazy functions. 611 // Parse and don't allow skipping lazy functions.
612 if (ParserApi::Parse(&info, kNoParsingFlags)) { 612 if (Parser::Parse(&info)) {
613 // Compile the code. 613 // Compile the code.
614 LiveEditFunctionTracker tracker(info.isolate(), info.function()); 614 LiveEditFunctionTracker tracker(info.isolate(), info.function());
615 if (Compiler::MakeCodeForLiveEdit(&info)) { 615 if (Compiler::MakeCodeForLiveEdit(&info)) {
616 ASSERT(!info.code().is_null()); 616 ASSERT(!info.code().is_null());
617 tracker.RecordRootFunctionInfo(info.code()); 617 tracker.RecordRootFunctionInfo(info.code());
618 } else { 618 } else {
619 info.isolate()->StackOverflow(); 619 info.isolate()->StackOverflow();
620 } 620 }
621 } 621 }
622 } 622 }
(...skipping 1496 matching lines...) Expand 10 before | Expand all | Expand 10 after
2119 2119
2120 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) { 2120 bool LiveEditFunctionTracker::IsActive(Isolate* isolate) {
2121 return false; 2121 return false;
2122 } 2122 }
2123 2123
2124 #endif // ENABLE_DEBUGGER_SUPPORT 2124 #endif // ENABLE_DEBUGGER_SUPPORT
2125 2125
2126 2126
2127 2127
2128 } } // namespace v8::internal 2128 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/hydrogen.cc ('k') | src/parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698