Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Unified Diff: runtime/vm/service.cc

Issue 1344993002: Refactor isolate interrupts to use OOB messages instead of interrupt bits. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: code review 2 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/service.cc
diff --git a/runtime/vm/service.cc b/runtime/vm/service.cc
index 4cb379eeb177e48843c5bef39274597f6054cc35..1dc403b15ffc2cfc67d5c998bb0dd50447365932 100644
--- a/runtime/vm/service.cc
+++ b/runtime/vm/service.cc
@@ -2423,8 +2423,12 @@ static const MethodParameter* pause_params[] = {
static bool Pause(Isolate* isolate, JSONStream* js) {
- // TODO(turnidge): Don't double-interrupt the isolate here.
- isolate->ScheduleInterrupts(Isolate::kApiInterrupt);
+ // TODO(turnidge): This interrupt message could have been sent from
+ // the service isolate directly, but would require some special case
+ // code. That would prevent this isolate getting double-interrupted
+ // with OOB messages.
+ isolate->SendInternalLibMessage(Isolate::kInterruptMsg,
+ isolate->pause_capability());
PrintSuccess(js);
return true;
}
« no previous file with comments | « runtime/vm/isolate.cc ('k') | runtime/vm/service/service.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698