runtime/vm/debugger.h - Issue 1344993002: Refactor isolate interrupts to use OOB messages instead of interrupt bits.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/debugger.h

Issue 1344993002: Refactor isolate interrupts to use OOB messages instead of interrupt bits. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code review 2 Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/debugger.h

diff --git a/runtime/vm/debugger.h b/runtime/vm/debugger.h

index cf6562ad18ca29ffd48e941c5c1edf1ec6cf2e4c..7c4cb8a3436a79452b680be789b8741a9e4eb923 100644

--- a/runtime/vm/debugger.h

+++ b/runtime/vm/debugger.h

@@ -556,14 +556,14 @@ class Debugger {

RawObject* GetStaticField(const Class& cls,

const String& field_name);

- void SignalBpReached();

- void DebuggerStepCallback();

+ RawError* SignalBpReached();

+ RawError* DebuggerStepCallback();

+ RawError* SignalIsolateInterrupted();

void BreakHere(const String& msg);

void SignalExceptionThrown(const Instance& exc);

void SignalIsolateEvent(DebuggerEvent::EventType type);

- static void SignalIsolateInterrupted();

RawCode* GetPatchedStubAddress(uword breakpoint_address);

« no previous file with comments | « runtime/vm/dart_api_impl.cc ('k') | runtime/vm/debugger.cc » ('j') | no next file with comments »